fix: not correctly released when an exception occurs during function execution

Author: HarlonWang

native/cpp/quickjs_wrapper.cpp

@@ -551,6 +551,7 @@ jobject QuickJSWrapper::call(JNIEnv *env, jobject thiz, jlong func, jlong this_o
 
     JSValue ret = JS_Call(context, jsFunc, jsObj, arguments.size(), arguments.data());
     if (JS_IsException(ret)) {
+        JS_FreeValue(context, ret);
         throwJSException(env, context);
         return nullptr;
     }

wrapper-android/src/androidTest/java/com/whl/quickjs/wrapper/QuickJSTest.java

@@ -1331,4 +1331,26 @@ public void testArraySameRefToMap() {
         }
     }
 
+    @Test
+    public void testCallThrowError() {
+        QuickJSContext context = createContext();
+        JSFunction function = null;
+        try {
+            function = (JSFunction) context.evaluate("function testThrowError() {\n" +
+                    "\tthrow new Error(\"test\");\n" +
+                    "}\n" +
+                    "\n" +
+                    "testThrowError;");
+            function.call();
+        } catch (Exception e) {
+            if (function != null) {
+                // 测试
+                function.release();
+            }
+            int defaultLength = 1;
+            assertEquals(defaultLength, context.getObjectRecords().size());
+            context.destroy();
+        }
+    }
+
 }

wrapper-java/src/main/java/com/whl/quickjs/wrapper/QuickJSFunction.java

@@ -44,16 +44,22 @@ public Object call(Object... args) {
         checkRefCountIsZero();
 
         currentStatus = Status.CALLING;
-        Object ret = getContext().call(this, thisPointer, thisPointerTag, args);
-        currentStatus = Status.CALLED;
+        Object ret;
+        try {
+            ret = getContext().call(this, thisPointer, thisPointerTag, args);
+        } finally {
+            // call 可能会抛出异常，需要保障以下代码被执行，不然因为状态不对，导致无法正常 release。
+            currentStatus = Status.CALLED;
 
-        if (stashTimes > 0) {
-            // 如果有暂存，这里需要恢复下 release 操作
-            for (int i = 0; i < stashTimes; i++) {
-                release();
+            if (stashTimes > 0) {
+                // 如果有暂存，这里需要恢复下 release 操作
+                for (int i = 0; i < stashTimes; i++) {
+                    release();
+                }
+                stashTimes = 0;
             }
-            stashTimes = 0;
         }
+
         return ret;
     }