fix a bug in FUN_nc_OpenDAP_with_limit: some useless codes introduced in an early version create a nan matrix with same size of the data to be downloaded. This may lead to an out-of-memory error.

Author: HappySpring

FUN_nc_OpenDAP_with_limit.m

@@ -61,6 +61,9 @@ function FUN_nc_OpenDAP_with_limit( filename0, filename1, dim_limit_name, dim_li
 % 
 % % Another example for 2D lon/lat cases is attached to the end.
 
+% By L. Chi, V1.62 2022-07-27: fix a bug: Some old codes will create a large nan matrix before downloading a large dataset no matter whether  
+%                                "divided_dim_str" is set or not. The nan matrix is may lead to an out-of-memory error and it is useless. 
+%                                Related codes have been commented and will be removed in a later version. 
 % By L. Chi, V1.61 2021-08-16: correct a typo ("compressiion_level" -> "compression_level")
 % By L. Chi, V1.60 2021-07-28: Put all operations to source files in try-catch blocks to survive from internet/server errors. 
 %
@@ -421,22 +424,22 @@ function FUN_nc_OpenDAP_with_limit( filename0, filename1, dim_limit_name, dim_li
         % The data will be donwloaded peice by piece by piece according to the last dim. 
 
         disp([datestr(now) ' downloading ' info0.Variables(iv).Name ])
-        if all( size(count) == 1 ) % in case of count = 5 instead of [5 6 7 8]
-            var_value = nan(count,1);
-        else
-            var_value = nan(count);
-        end
+        %if all( size(count) == 1 ) % in case of count = 5 instead of [5 6 7 8]
+        %    var_value = nan(count,1);
+        %else
+        %    var_value = nan(count);
+        %end
         divided_dim = FUN_struct_find_field_ind( VarDim_now, 'Name', divided_dim_str );
 
         % make the divided_dim as the last dim.
-         [var_value, tem_ind_reverse] = FUN_dim_move_to_end(var_value, divided_dim );
-        tem_size  = size( var_value );
-            % check
-            if count(divided_dim) == tem_size(end) 
-            else
-               error('dimension error') 
-            end
-        var_value = reshape( var_value, [], count(divided_dim) );
+        % [var_value, tem_ind_reverse] = FUN_dim_move_to_end(var_value, divided_dim );
+        %tem_size  = size( var_value );
+        %    % check
+        %    if count(divided_dim) == tem_size(end) 
+        %    else
+        %       error('dimension error') 
+        %    end
+        % var_value = reshape( var_value, [], count(divided_dim) );
 
 
         % prepare for loading the index by groups

FUN_nc_varget_enhanced_from_multifiles.m

@@ -64,7 +64,7 @@
 is_1D = length(var_size1) == 2 && any( var_size1 == 1 );
 var_size2 = var_size1;
 
-if dim_ind == length( var_size1 ) || is_1D;
+if dim_ind == length( var_size1 ) || is_1D
     % ok
 else
     error('The merged dim must be the last dimension. Other conditions are not supported yet')
@@ -81,7 +81,7 @@
 out_sourcefile_ind = nan( 1, MV.N );
 
 %% load/write variable
-    for ii = 1:length( filelist );
+    for ii = 1:length( filelist )
         disp(['Loading from ' fullfile( input_dir, filelist(ii).name ) ])
         out_var(:, MV.ind_start(ii): MV.ind_end(ii)) = reshape( FUN_nc_varget_enhanced( fullfile( input_dir, filelist(ii).name ), var_name ), NX, [] );
         out_sourcefile_ind( MV.ind_start(ii): MV.ind_end(ii) ) = ii;

private/FUN_codetool_retry.m

@@ -65,15 +65,15 @@
         count_err = count_err + 1;
 
         fprintf(' \n' );
-        disp(['Err, retry count: ' num2str( count_err )] );
+        warning(['Err, retry count: ' num2str( count_err )] );
 
         fprintf('Wait for %.2f seconds ... \n', pause_seconds );
         pause(pause_seconds) %retry after 30 seconds
 
         fprintf('>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>\n' );
 
         if count_err == N_max_retry
-            fprintf('>>>>>> Reach N_max_retry(=%i), stop <<<<<< \n', N_max_retry)
+            warning('>>>>>> Reach N_max_retry(=%i), stop <<<<<< \n', N_max_retry)
             % This will return an error message by default
             [varargout{1:nargout}] = else_fun();
         end