-
-
Notifications
You must be signed in to change notification settings - Fork 98
Add swapperoo #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swapperoo #3645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, just a few minor things. We should also make sure the intention preview is working (if you hover over the intention name)
Do we want to maybe filter out commands like href whose required args are not interchangeable?
I don't think so, if I for example messed up the order of arguments for href this intention would be really useful to switch them to the correct place
src/nl/hannahsten/texifyidea/intentions/LatexFlipArgumentsIntention.kt
Outdated
Show resolved
Hide resolved
|
I got it working in the ide, but it wont pass any tests. |
|
Thanks, you were nearly there! I changed two things:
Please check if I missed any edge cases though. |
Fix #3643
Very simple, added tests. Do we want to maybe filter out commands like
hrefwhose required args are not interchangeable?