Merge pull request #439 from fridaland/fix-gifted-segment-calls

Fix bad conditional transition event check for 'gifted' segment calls

Author: johndbritton

app/services/user_state_transition_segment_service.rb

@@ -15,7 +15,7 @@ def call(user, transition)
     when :incomplete then incomplete(user)
     when :ineligible then ineligible(user)
     when :won then won(user, transition)
-    when :gift_sticker then gift_sticker(user)
+    when :gifted then gifted(user)
     end
   end
 
@@ -62,7 +62,9 @@ def won(user, transition)
     end
   end
 
-  def gift_sticker(user)
+  # TODO: change this to gifted(user, transition) and check transition.to to
+  # add case for 'gifted_shirt'
+  def gifted(user)
     segment(user).identify(state: 'gifted_sticker')
     segment(user).track('user_gifted_sticker')
   end

spec/models/user_spec.rb

@@ -522,7 +522,7 @@
   describe '#gift' do
     before do
       allow(UserStateTransitionSegmentService)
-        .to receive(:gift_sticker).and_return(true)
+        .to receive(:gifted).and_return(true)
     end
 
     context 'the user is in the incompleted state' do

spec/services/gift_service_spec.rb

@@ -31,6 +31,7 @@
 
       context 'there is 1 sticker coupon' do
         before do
+          allow(UserStateTransitionSegmentService).to receive(:call)
           FactoryBot.create(:sticker_coupon)
           GiftService.call
         end
@@ -44,6 +45,7 @@
 
       context 'there are 2 sticker coupons' do
         before do
+          allow(UserStateTransitionSegmentService).to receive(:call)
           FactoryBot.create(:sticker_coupon)
           FactoryBot.create(:sticker_coupon)
           GiftService.call
@@ -64,6 +66,7 @@
 
       context 'there are 3 sticker coupons' do
         before do
+          allow(UserStateTransitionSegmentService).to receive(:call)
           FactoryBot.create(:sticker_coupon)
           FactoryBot.create(:sticker_coupon)
           FactoryBot.create(:sticker_coupon)

spec/services/user_state_transition_segment_service_spec.rb

@@ -186,11 +186,11 @@
       end
     end
 
-    context 'the event is gift_sticker and the user is incompleted' do
+    context 'the event is gifted and the user is incompleted' do
       let(:user) { FactoryBot.create(:user, :incompleted) }
 
       before do
-        allow(transition).to receive(:event).and_return(:gift_sticker)
+        allow(transition).to receive(:event).and_return(:gifted)
       end
 
       it 'calls SegmentService#identify with proper arguments' do