Skip to content

Experimental support for merged_prefill #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 3, 2025

Conversation

madamczyk-intel
Copy link

@madamczyk-intel madamczyk-intel commented Mar 31, 2025

Based on work by @xuechendi in #643
and by @kamil-kaczor in #893

Requires: HabanaAI/vllm-hpu-extension#131

As of now only V0 is supported. V1 support will be added in next PRs

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
…age1

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
@madamczyk-intel
Copy link
Author

/run-gaudi-tests

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
@madamczyk-intel
Copy link
Author

/run-gaudi-tests

@madamczyk-intel
Copy link
Author

/run-gaudi-tests

@madamczyk-intel
Copy link
Author

/run-gaudi-tests

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
@madamczyk-intel
Copy link
Author

/run-gaudi-tests

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
@madamczyk-intel
Copy link
Author

/run-gaudi-tests

@madamczyk-intel
Copy link
Author

/run-gaudi-tests

Copy link

@kamil-kaczor kamil-kaczor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added single suggestion but overall LGTM

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
@madamczyk-intel
Copy link
Author

/run-gaudi-tests

1 similar comment
@madamczyk-intel
Copy link
Author

/run-gaudi-tests

@madamczyk-intel
Copy link
Author

/run-gaudi-tests

@madamczyk-intel
Copy link
Author

/run-gaudi-tests

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
@madamczyk-intel
Copy link
Author

/run-gaudi-tests

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
@afierka-intel
Copy link

/run-gaudi-tests

Signed-off-by: Michal Adamczyk <madamczyk@habana.ai>
@afierka-intel
Copy link

/run-gaudi-tests

@madamczyk-intel
Copy link
Author

/run-gaudi-tests

1 similar comment
@madamczyk-intel
Copy link
Author

/run-gaudi-tests

@afierka-intel afierka-intel merged commit bd95983 into habana_main Apr 3, 2025
43 checks passed
@afierka-intel afierka-intel deleted the dev/madamczyk/merged_prefill_stage1 branch April 3, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants