Skip to content

Commit da2fce7

Browse files
committed
Change dockerfile and readme.
1 parent 353dc8b commit da2fce7

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ COPY . .
1010
# These are for more configurability (as opposed to having keys directly in code).
1111
ARG REACT_APP_DEV_API_SUBSCRIPTION_KEY=""
1212
ARG REACT_APP_API_SUBSCRIPTION_KEY=""
13-
ENV REACT_APP_API_SUBSCRIPTION_KEY_PARAM=digitransit-subscription-key
13+
ARG REACT_APP_API_SUBSCRIPTION_KEY_PARAM=""
14+
ENV REACT_APP_API_SUBSCRIPTION_KEY_PARAM=$REACT_APP_API_SUBSCRIPTION_KEY_PARAM
1415
ENV REACT_APP_DEV_API_SUBSCRIPTION_KEY=$REACT_APP_DEV_API_SUBSCRIPTION_KEY
1516
ENV REACT_APP_API_SUBSCRIPTION_KEY=$REACT_APP_API_SUBSCRIPTION_KEY
1617

README.md

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,25 @@ Deployment for HSL version of [GraphiQL](https://github.com/graphql/graphiql). P
88
REACT_APP_DEV_API_SUBSCRIPTION_KEY=key REACT_APP_API_SUBSCRIPTION_KEY=key REACT_APP_API_SUBSCRIPTION_KEY_PARAM=digitransit-subscription-key yarn start
99
```
1010

11-
Environment variables `REACT_APP_DEV_API_SUBSCRIPTION_KEY`, `REACT_APP_API_SUBSCRIPTION_KEY` and `REACT_APP_API_SUBSCRIPTION_KEY_PARAM` are set to GraphQL request query string for authorization gateway service.
11+
Environment variables `REACT_APP_DEV_API_SUBSCRIPTION_KEY`, `REACT_APP_API_SUBSCRIPTION_KEY`, and `REACT_APP_API_SUBSCRIPTION_KEY_PARAM` are set in the GraphQL request query string for the authorization gateway service.
1212

13-
## Run in docker
13+
## Docker
1414

15+
### Build
1516
```sh
16-
docker build -t graphiql .
17-
docker run -it \
18-
-p 8099:8080 \
19-
-e REACT_APP_DEV_API_SUBSCRIPTION_KEY=key \
20-
-e REACT_APP_API_SUBSCRIPTION_KEY=key \
21-
-e REACT_APP_API_SUBSCRIPTION_KEY_PARAM=digitransit-subscription-key \
22-
graphiql
17+
docker build \
18+
--build-arg REACT_APP_DEV_API_SUBSCRIPTION_KEY=key \
19+
--build-arg REACT_APP_API_SUBSCRIPTION_KEY=key \
20+
--build-arg REACT_APP_API_SUBSCRIPTION_KEY_PARAM=digitransit-subscription-key \
21+
-t graphiql .
2322
```
2423

25-
## Code formatting
26-
27-
Format source codebase:
24+
### Run
25+
```sh
26+
docker run -it -p 8099:8080 graphiql
27+
```
2828

29+
## Code formatting
2930
```sh
30-
yarn format
31+
yarn lint
3132
```

0 commit comments

Comments
 (0)