fix problem on reference generator - refactor

Author: SSEsmaeeli

config/pay-pocket.php

@@ -14,6 +14,7 @@
  */
 return [
     'log_reference_length' => 12,
-    'log_reference_prefix' => null,
-    'log_reference_generator' => null,
+    'log_reference_prefix' => '',
+    'log_reference_generator_class' => Illuminate\Support\Str::class,
+    'log_reference_generator_method' => 'random',
 ];

src/Models/WalletsLog.php

@@ -10,6 +10,14 @@
  * HPWebdeveloper\LaravelPayPocket\Models\WalletsLog
  *
  * @property string $status
+ * @property int|float $from
+ * @property int|float $to
+ * @property string $type
+ * @property string $ip
+ * @property int|float $value
+ * @property string $wallet_name
+ * @property string $notes
+ * @property string $reference
  */
 class WalletsLog extends Model
 {

src/Traits/BalanceOperation.php

@@ -2,11 +2,12 @@
 
 namespace HPWebdeveloper\LaravelPayPocket\Traits;
 
-use Illuminate\Support\Str;
+use HPWebdeveloper\LaravelPayPocket\Models\WalletsLog;
+use InvalidArgumentException;
 
 trait BalanceOperation
 {
-    protected $createdLog;
+    protected WalletsLog $createdLog;
 
     /**
      * Check if Balance is more than zero.
@@ -43,29 +44,37 @@ protected function createLog(string $logType, int|float $value, ?string $notes =
 
         $newBalance = $logType === 'dec' ? $currentBalance - $value : $currentBalance + $value;
 
-        $refGen = config('pay-pocket.log_reference_generator', [
-            Str::class, 'random', [config('pay-pocket.log_reference_length', 12)],
-        ]);
-        $refGen = [
-            Str::class, 'random', [config('pay-pocket.log_reference_length', 12)],
-        ];
-
-        $reference = config('pay-pocket.reference_string_prefix', '');
-        $reference .= isset($refGen[0], $refGen[1])
-            ? $refGen[0]::{$refGen[1]}(...$refGen[2] ?? [])
-            : Str::random(config('pay-pocket.log_reference_length', 12));
-
+        /** @var \Illuminate\Database\Eloquent\Model $this */
         $this->createdLog = $this->logs()->create([
             'wallet_name' => $this->type->value,
             'from' => $currentBalance,
             'to' => $newBalance,
             'type' => $logType,
-            'ip' => \Request::ip(),
+            'ip' => request()->ip(),
             'value' => $value,
             'notes' => $notes,
-            'reference' => $reference,
+            'reference' => $this->generateReference(),
         ]);
 
         $this->createdLog->changeStatus('Done');
     }
+
+    /**
+     * @throws InvalidArgumentException
+     */
+    protected function generateReference(): string
+    {
+        $className = config('pay-pocket.log_reference_generator_class');
+        $methodName = config('pay-pocket.log_reference_generator_method');
+        $length = config('pay-pocket.log_reference_length');
+        $prefix = config('pay-pocket.log_reference_prefix');
+
+        if (!is_callable([$className, $methodName])) {
+            throw new InvalidArgumentException('Invalid configuration: The combination of log_reference_generator_class and log_reference_generator_method is not callable.');
+        }
+
+        $reference = call_user_func([$className, $methodName], $length);
+
+        return $prefix . $reference;
+    }
 }