Skip to content

Commit 8d3794d

Browse files
authored
fix(i18n): split game.version to make different scenarios appropriate (#3709)
- `game.version` indicates the currently used game instance in the game crash window, not the game version. - Change the i18n key previously used in ModListPageSkin to `mods.game.version`, to be consistent with the world section.
1 parent d1b59ef commit 8d3794d

File tree

6 files changed

+9
-4
lines changed

6 files changed

+9
-4
lines changed

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ static class ModInfoObject extends RecursiveTreeObject<ModInfoObject> implements
290290

291291
StringBuilder message = new StringBuilder(localModFile.getFileName());
292292
if (isNotBlank(localModFile.getGameVersion()))
293-
message.append(", ").append(i18n("game.version")).append(": ").append(localModFile.getGameVersion());
293+
message.append(", ").append(i18n("mods.game.version")).append(": ").append(localModFile.getGameVersion());
294294
if (isNotBlank(localModFile.getAuthors()))
295295
message.append(", ").append(i18n("archive.author")).append(": ").append(localModFile.getAuthors());
296296
this.message = message.toString();

HMCL/src/main/resources/assets/lang/I18N.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ game.crash.reason.unsatisfied_link_error=Failed to launch Minecraft because of m
654654
Otherwise, if you believe this is caused by HMCL, please provide feedback to us.
655655
game.crash.title=Game Crashed
656656
game.directory=Game Path
657-
game.version=Game Version
657+
game.version=Game Instance
658658

659659
help=Help
660660
help.doc=Hello Minecraft! Launcher Documentation
@@ -1015,6 +1015,7 @@ mods.download=Download Mod
10151015
mods.download.title=Download Mod - %1s
10161016
mods.download.recommend=Recommended Mod Version - Minecraft %1s
10171017
mods.enable=Enable
1018+
mods.game.version=Game Version
10181019
mods.manage=Mods
10191020
mods.mcbbs=MCBBS
10201021
mods.mcmod=MCMod

HMCL/src/main/resources/assets/lang/I18N_es.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,7 @@ game.crash.reason.too_many_mods_lead_to_exceeding_the_id_limit=El juego se ha co
658658
Por favor, intenta instalar <a href="https://www.curseforge.com/minecraft/mc-mods/jeid">JEID</a> o eliminar algunos mods grandes.
659659
game.crash.title=Juego colgado
660660
game.directory=Ruta del juego
661-
game.version=Versión del juego
661+
game.version=Instancia del juego
662662

663663
help=Ayuda
664664
help.doc=Documentación de Hello Minecraft! Launcher
@@ -1019,6 +1019,7 @@ mods.download=Descargar mod
10191019
mods.download.title=Descargar mod - %1s
10201020
mods.download.recommend=Versión recomendada - Minecraft %1s
10211021
mods.enable=Activar
1022+
mods.game.version=Versión del juego
10221023
mods.manage=Mods
10231024
mods.mcbbs=MCBBS
10241025
mods.mcmod=MCMod

HMCL/src/main/resources/assets/lang/I18N_ru.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,6 +1018,7 @@ mods.download=Скачать мод
10181018
mods.download.title=Скачать мод - %1s
10191019
mods.download.recommend=Рекомендуемая версия мода - Minecraft %1s
10201020
mods.enable=Включить
1021+
mods.game.version=Версия игры
10211022
mods.manage=Моды
10221023
mods.mcbbs=MCBBS
10231024
mods.mcmod=MCMod

HMCL/src/main/resources/assets/lang/I18N_zh.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,7 @@ game.crash.reason.unknown=原因未知,請點擊日誌按鈕查看詳細訊息
470470
game.crash.reason.unsatisfied_link_error=目前遊戲由於缺少本機庫,無法繼續執行。\n這些本機庫缺失:%1$s。\n如果你在「(全域/實例特定) 遊戲設定 → 進階設定」中修改了本機庫路徑選項,請你修改回預設模式。\n如果你正在使用預設模式,請檢查遊戲目錄路徑是否只包含英文字母、數字和底線,\n如果是,那麼請檢查是否為模組或 HMCL 導致了本機庫缺失的問題。如果你確定是 HMCL 引起的,建議你向我們回報。\n<b>對於 Windows 使用者,你還可以嘗試在「控制台 → 時鐘和區域 → 地區 → 系統管理 → 變更系統區域設定」中,關閉「Beta:使用 Unicode UTF-8 提供全球語言支援」選項;</b>\n<b>或將遊戲目錄路徑中的所有非英文字母的名稱 (例如中文、空格等) 修改為英文字母。</b>\n如果你確實需要自訂本機庫路徑,你需要保證其中包含缺失的本機庫!
471471
game.crash.title=遊戲意外退出
472472
game.directory=遊戲目錄路徑
473-
game.version=遊戲版本
473+
game.version=遊戲實例
474474

475475
help=說明
476476
help.doc=Hello Minecraft! Launcher 說明文件
@@ -821,6 +821,7 @@ mods.download=模組下載
821821
mods.download.title=模組下載 - %1s
822822
mods.download.recommend=推薦版本 - Minecraft %1s
823823
mods.enable=啟用
824+
mods.game.version=遊戲版本
824825
mods.manage=模組管理
825826
mods.mcbbs=MCBBS
826827
mods.mcmod=MC 百科

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -832,6 +832,7 @@ mods.download=模组下载
832832
mods.download.title=模组下载 - %1s
833833
mods.download.recommend=推荐版本 - Minecraft %1s
834834
mods.enable=启用
835+
mods.game.version=游戏版本
835836
mods.manage=模组管理
836837
mods.mcbbs=MCBBS
837838
mods.mcmod=MC 百科

0 commit comments

Comments
 (0)