Skip to content

Commit 2b08ac0

Browse files
authored
bugfix: unable to communicate with LSP on Windows 10 (#155)
* use SecurityIdentifier everyone * bumped version to 2.0.1.0
1 parent 095211d commit 2b08ac0

File tree

6 files changed

+10
-25
lines changed

6 files changed

+10
-25
lines changed

VS/CSHARP/asm-dude2-ls/Worker.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System.IO.Pipes;
22
using System.Runtime.InteropServices;
3+
using System.Security.Principal;
34

45
namespace AsmDude2LS;
56

@@ -34,7 +35,8 @@ public Worker(ILogger<Worker> logger)
3435
const string stdInPipeName = @"input";
3536
const string stdOutPipeName = @"output";
3637

37-
PipeAccessRule pipeAccessRule = new("Everyone", PipeAccessRights.ReadWrite, System.Security.AccessControl.AccessControlType.Allow);
38+
SecurityIdentifier everyone = new(WellKnownSidType.WorldSid, null);
39+
PipeAccessRule pipeAccessRule = new(everyone, PipeAccessRights.ReadWrite, System.Security.AccessControl.AccessControlType.Allow);
3840
PipeSecurity pipeSecurity = new();
3941
pipeSecurity.AddAccessRule(pipeAccessRule);
4042

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.0.0.4
1+
1.0.1.0

VS/CSHARP/asm-dude2-vsix/AsmLanguageClient.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
using AsmDude2.Tools;
3737
using AsmTools;
3838
using System.Windows.Forms;
39+
using System.Security.Principal;
3940

4041
namespace AsmDude2
4142
{
@@ -261,8 +262,9 @@ public async Task<Connection> ActivateAsync(CancellationToken token)
261262
const string stdInPipeName = @"output";
262263
const string stdOutPipeName = @"input";
263264

264-
var pipeAccessRule = new PipeAccessRule("Everyone", PipeAccessRights.ReadWrite, System.Security.AccessControl.AccessControlType.Allow);
265-
var pipeSecurity = new PipeSecurity();
265+
SecurityIdentifier everyone = new SecurityIdentifier(WellKnownSidType.WorldSid, null);
266+
PipeAccessRule pipeAccessRule = new PipeAccessRule(everyone, PipeAccessRights.ReadWrite, System.Security.AccessControl.AccessControlType.Allow);
267+
PipeSecurity pipeSecurity = new PipeSecurity();
266268
pipeSecurity.AddAccessRule(pipeAccessRule);
267269

268270
var bufferSize = 256;

VS/CSHARP/asm-dude2-vsix/Properties/AssemblyInfo.cs

Lines changed: 0 additions & 19 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.0.0.5
1+
2.0.1.0

VS/CSHARP/asm-dude2-vsix/source.extension.vsixmanifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
33
<Metadata>
4-
<Identity Id="AsmDude2" Version="2.0.0.5" Language="en-US" Publisher="Henk-Jan Lebbink" />
4+
<Identity Id="AsmDude2" Version="2.0.1.0" Language="en-US" Publisher="Henk-Jan Lebbink" />
55
<DisplayName>AsmDude2</DisplayName>
66
<Description xml:space="preserve">Syntax highlighting and code assistance for assembly source code (.asm, .cod, .inc, .s) and the Disassembly Window.</Description>
77
</Metadata>

0 commit comments

Comments
 (0)