Skip to content

Commit 49951de

Browse files
authored
Update api.py
1 parent 48b9733 commit 49951de

File tree

1 file changed

+14
-25
lines changed
  • custom_components/apsystems_ecu_proxy

1 file changed

+14
-25
lines changed

custom_components/apsystems_ecu_proxy/api.py

Lines changed: 14 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ async def data_received(
114114
response = await self.send_data_to_ema(self.port, data)
115115
await self.send_data_to_ecu(writer, response)
116116

117-
# MessageFilter: whitelist data message and message checksum
117+
# MessageFilter: whitelist data message and message checksum.
118118
if (
119119
not message.startswith("APS18AA")
120120
or int(message[7:10]) != len(message) - 1
@@ -129,13 +129,7 @@ async def data_received(
129129
)
130130
return None
131131

132-
_LOGGER.debug(
133-
"Processing message from ECU @ %s on port %s - %s",
134-
addr[0],
135-
self.port,
136-
message.replace("\n", ""),
137-
)
138-
# Get & interpret ECU data
132+
# Get & interpret ECU data.
139133
ecu["ecu-id"] = message[18:30]
140134
ecu["model"] = self.get_model(message[18:22])
141135
ecu["lifetime_energy"] = int(message[42:60]) / 10
@@ -144,31 +138,26 @@ async def data_received(
144138
ecu["inverters"] = self.get_inverters(ecu["ecu-id"], message)
145139
ecu["timestamp"] = datetime.strptime(message[60:74], "%Y%m%d%H%M%S")
146140

147-
# When 5 minute update interval expires, stop graphs
141+
# MessageFilter: Ignore old messages.
148142
if (
149143
message_age := (datetime.now() - ecu["timestamp"]).total_seconds()
150144
) > MESSAGE_IGNORE_AGE:
151-
_LOGGER.debug(
152-
"Message told old with %s sec, stopping graphs",
145+
_LOGGER.warning(
146+
"Message told old with %s sec.",
153147
int(message_age),
154148
)
155-
ecu["timestamp"] = datetime.now().replace(microsecond=0)
156-
ecu["current_power"] = 0
157-
ecu["qty_of_online_inverters"] = 0
158-
# Iterate through each inverter and update the values
159-
for inverter in ecu["inverters"].values():
160-
inverter["frequency"] = 0
161-
inverter["power"] = [0] * len(inverter["power"])
162-
inverter["voltage"] = [0] * len(inverter["voltage"])
163-
inverter["current"] = [0] * len(inverter["current"])
164-
inverter["temperature"] = None
165-
inverter["frequency"] = 0.0
149+
return None
150+
151+
_LOGGER.warning(
152+
"Processing message from ECU @ %s on port %s - %s",
153+
addr[0],
154+
self.port,
155+
message.replace("\n", ""),
156+
)
157+
166158
self.callback(ecu)
167159
except ConnectionResetError:
168160
_LOGGER.warning("Error: Connection was reset")
169-
# except Exception as error:
170-
# _LOGGER.warning("Exception error with %s", error)
171-
# alternative
172161
except Exception: # noqa: BLE001
173162
_LOGGER.warning("Exception error with %s", traceback.format_exc())
174163

0 commit comments

Comments
 (0)