Bug: Orphan types are ignored since version 3.8.5

[psyho]

Up to and including version 3.8.4, the following code worked:

class ApplicationSchema < GraphQL::Schema
  include ApolloFederation::Schema
  
  query QueryType
  
  orphan_types [FooType]
end

Because of the change in #270 this code doesn't work anymore. The orphan types are ignored. I suspect it's because the previous logic overrode the original query type with federation-specific query type lazily, and the current implementation is eager.

The workaround is to define orphan_types before query, but that's still an undesired and breaking change.

[darla-ahlert]

Just confirming, do you mean 3.8.4/5 here (not v2)?

[psyho]

@darla-ahlert 🤦‍♂️ thank you for pointing it out - yes, I mean 3.8.*

[djkgamc]

This was my last 4 hours! Shit and thank you. I guess the best workaround is pin to 3.8.4 in the meantime.

[DiscreteObject]

This also bit us when upgrading past 3.8.4 (started with 3.10.1 but backtracked to 3.8.5 to identify the offending change). It seems to work with the workaround of defining orphan_types earlier in the schema definition, but as the OP notes that's potentially problematic.