fix(securitycenter): delete deprecated samples and fix failing samples (#13223)

* fix(securitycenter): unify syntax for datetime and remove deprecation warnings

- Use same importing style for all datetime objects across samples
- Use a timezone compatible with Python 3.9 (as datetime.UTC was added in Python 3.11)
- Remove deprecation warning for utcnow()
- Add debug prints to watch failing tests

* fix(securitycenter): minor fixes and lint

- Fix linting problem when indicating Python interpreter on line 1
- Fix style

* fix(securitycenter): update to latest dependencies

* fix(securitycenter): revert to previous versions of dependencies

* fix(securitycenter): comment parameter to check if that skips 400 Request contains an invalid argument.

* fix(securitycenter): remove UTC timezone to validate a conversion problem

* fix(securitycenter): delete samples

- securitycenter_group_findings_with_changes
- securitycenter_group_findings_at_time

* fix(securitycenter): try fixing list_findings_at_time

* fix(securitycenter): update pubsub version

- Try to remove "google.cloud.securitycenter.v1.Finding" has no field named "muteInfo"

* fix(securitycenter): fix linting

* fix(securitycenter): fix date conversion to string

* fix(security): update securitycenter version

* fix(securitycenter): update google-cloud-bigquery

* fix(securitycenter): change imports from 'securitycenter' to 'securitycenter_v1' to make it explicit

* fix(securitycenter): fix missing rename

* fix(securitycenter): add backoff to 'test_update_asset_discovery_org_settings' to retry on Aborted exception

* fix(securitycenter): aim for the assert value in list_findings_at_time

* fix(securitycenter): add backoff to receive_notifications

* fix(securitycenter): fix linting

* fix(securitycenter): try to fix exception in receive_notifications

* fix(securitycenter): catch a ParseError on messages

* fix(securitycenter): fix linting

* fix(securitycenter): fix typo and revert deleted comment

Author: eapl-gemugami

securitycenter/snippets/requirements-test.txt

@@ -1,3 +1,3 @@
 backoff==2.2.1
 pytest==8.2.0
-google-cloud-bigquery==3.25.0
+google-cloud-bigquery==3.30.0

securitycenter/snippets/requirements.txt

@@ -1,2 +1,2 @@
-google-cloud-pubsub==2.21.5
-google-cloud-securitycenter==1.21.0
+google-cloud-pubsub==2.28.0
+google-cloud-securitycenter==1.38.0

securitycenter/snippets/snippets_findings.py

@@ -20,9 +20,9 @@
 def create_source(organization_id):
     """Create a new findings source."""
     # [START securitycenter_create_source]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
     # organization_id is the numeric ID of the organization. e.g.:
     # organization_id = "111122222444"
     org_name = f"organizations/{organization_id}"
@@ -43,9 +43,9 @@ def create_source(organization_id):
 def get_source(source_name):
     """Gets an existing source."""
     # [START securitycenter_get_source]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -63,10 +63,10 @@ def get_source(source_name):
 def update_source(source_name):
     """Updates a source's display name."""
     # [START securitycenter_update_source]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
     from google.protobuf import field_mask_pb2
 
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # Field mask to only update the display name.
     field_mask = field_mask_pb2.FieldMask(paths=["display_name"])
@@ -91,11 +91,12 @@ def update_source(source_name):
 def add_user_to_source(source_name):
     """Gives a user findingsEditor permission to the source."""
     user_email = "csccclienttest@gmail.com"
+
     # [START securitycenter_set_source_iam]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
     from google.iam.v1 import policy_pb2
 
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -123,19 +124,19 @@ def add_user_to_source(source_name):
     )
 
     print(f"Updated Policy: {updated}")
-
     # [END securitycenter_set_source_iam]
+
     return binding, updated
 
 
 def list_source(organization_id):
     """Lists finding sources."""
     i = -1
     # [START securitycenter_list_sources]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
     # Create a new client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
     # 'parent' must be in one of the following formats:
     #   "organizations/{organization_id}"
     #   "projects/{project_id}"
@@ -152,16 +153,16 @@ def list_source(organization_id):
 def create_finding(source_name, finding_id):
     """Creates a new finding."""
     # [START securitycenter_create_finding]
-    import datetime
+    from datetime import datetime, timezone
 
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
     from google.cloud.securitycenter_v1 import Finding
 
     # Create a new client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # Use the current time as the finding "event time".
-    event_time = datetime.datetime.now(tz=datetime.timezone.utc)
+    event_time = datetime.now(tz=timezone.utc)
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -194,14 +195,14 @@ def create_finding(source_name, finding_id):
 def create_finding_with_source_properties(source_name):
     """Demonstrate creating a new finding with source properties."""
     # [START securitycenter_create_finding_with_source_properties]
-    import datetime
+    from datetime import datetime, timezone
 
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
     from google.cloud.securitycenter_v1 import Finding
     from google.protobuf.struct_pb2 import Value
 
     # Create a new client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -225,7 +226,7 @@ def create_finding_with_source_properties(source_name):
     num_value.number_value = 1234
 
     # Use the current time as the finding "event time".
-    event_time = datetime.datetime.now(tz=datetime.timezone.utc)
+    event_time = datetime.now(tz=timezone.utc)
 
     finding = Finding(
         state=Finding.State.ACTIVE,
@@ -244,13 +245,13 @@ def create_finding_with_source_properties(source_name):
 
 def update_finding(source_name):
     # [START securitycenter_update_finding_source_properties]
-    import datetime
+    from datetime import datetime, timezone
 
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
     from google.cloud.securitycenter_v1 import Finding
     from google.protobuf import field_mask_pb2
 
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
     # Only update the specific source property and event_time.  event_time
     # is required for updates.
     field_mask = field_mask_pb2.FieldMask(
@@ -259,7 +260,7 @@ def update_finding(source_name):
 
     # Set the update time to Now.  This must be some time greater then the
     # event_time on the original finding.
-    event_time = datetime.datetime.now(tz=datetime.timezone.utc)
+    event_time = datetime.now(tz=timezone.utc)
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -288,13 +289,13 @@ def update_finding(source_name):
 def update_finding_state(source_name):
     """Demonstrate updating only a finding state."""
     # [START securitycenter_update_finding_state]
-    import datetime
+    from datetime import datetime, timezone
 
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
     from google.cloud.securitycenter_v1 import Finding
 
     # Create a client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
     # Its format is:
@@ -308,7 +309,7 @@ def update_finding_state(source_name):
         request={
             "name": finding_name,
             "state": Finding.State.INACTIVE,
-            "start_time": datetime.datetime.now(tz=datetime.timezone.utc),
+            "start_time": datetime.now(timezone.utc),
         }
     )
     print(f"New state: {new_finding.state}")
@@ -319,10 +320,10 @@ def trouble_shoot(source_name):
     """Demonstrate calling test_iam_permissions to determine if the
     service account has the correct permisions."""
     # [START securitycenter_test_iam]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
     # Create a client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
     # Its format is:
@@ -356,15 +357,14 @@ def trouble_shoot(source_name):
     print(f"Permision to update state? {len(permission_response.permissions) > 0}")
     # [END securitycenter_test_iam]
     return permission_response
-    assert len(permission_response.permissions) > 0
 
 
 def list_all_findings(organization_id):
     # [START securitycenter_list_all_findings]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
     # Create a client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'parent' must be in one of the following formats:
     #   "organizations/{organization_id}"
@@ -387,10 +387,10 @@ def list_all_findings(organization_id):
 
 def list_filtered_findings(source_name):
     # [START securitycenter_list_filtered_findings]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
     # Create a new client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -419,12 +419,14 @@ def list_filtered_findings(source_name):
 
 def list_findings_at_time(source_name):
     # [START securitycenter_list_findings_at_time]
-    from datetime import datetime, timedelta
+    from datetime import datetime, timedelta, timezone
 
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
     # Create a new client.
-    client = securitycenter.SecurityCenterClient()
+    # More info about SecurityCenterClient:
+    # https://cloud.google.com/python/docs/reference/securitycenter/latest/google.cloud.securitycenter_v1.services.security_center.SecurityCenterClient
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -436,30 +438,39 @@ def list_findings_at_time(source_name):
     #   "folders/{folder_id}"
     # You an also use a wild-card "-" for all sources:
     #   source_name = "organizations/111122222444/sources/-"
-    five_days_ago = str(datetime.now() - timedelta(days=5))
+
+    five_days_ago = datetime.now(timezone.utc) - timedelta(days=5)
+    timestamp_milliseconds = int(five_days_ago.timestamp() * 1000)
     # [END securitycenter_list_findings_at_time]
     i = -1
     # [START securitycenter_list_findings_at_time]
 
+    # More details about the request syntax:
+    # https://cloud.google.com/security-command-center/docs/reference/rest/v1/folders.sources.findings/list
     finding_result_iterator = client.list_findings(
-        request={"parent": source_name, "filter": five_days_ago}
+        request={
+            "parent": source_name,
+            "filter": f"event_time < {timestamp_milliseconds}",
+        }
     )
+
     for i, finding_result in enumerate(finding_result_iterator):
         print(
             "{}: name: {} resource: {}".format(
                 i, finding_result.finding.name, finding_result.finding.resource_name
             )
         )
     # [END securitycenter_list_findings_at_time]
+
     return i
 
 
 def get_iam_policy(source_name):
     """Gives a user findingsEditor permission to the source."""
     # [START securitycenter_get_source_iam]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -477,10 +488,10 @@ def group_all_findings(organization_id):
     """Demonstrates grouping all findings across an organization."""
     i = 0
     # [START securitycenter_group_all_findings]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
     # Create a client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'parent' must be in one of the following formats:
     #   "organizations/{organization_id}"
@@ -503,10 +514,10 @@ def group_filtered_findings(source_name):
     """Demonstrates grouping all findings across an organization."""
     i = 0
     # [START securitycenter_group_filtered_findings]
-    from google.cloud import securitycenter
+    from google.cloud import securitycenter_v1
 
     # Create a client.
-    client = securitycenter.SecurityCenterClient()
+    client = securitycenter_v1.SecurityCenterClient()
 
     # 'source_name' is the resource path for a source that has been
     # created previously (you can use list_sources to find a specific one).
@@ -529,75 +540,3 @@ def group_filtered_findings(source_name):
         print((i + 1), group_result)
     # [END securitycenter_group_filtered_findings]
     return i
-
-
-def group_findings_at_time(source_name):
-    """Demonstrates grouping all findings across an organization as of
-    a specific time."""
-    i = -1
-    # [START securitycenter_group_findings_at_time]
-    from datetime import datetime, timedelta
-
-    from google.cloud import securitycenter
-
-    # Create a client.
-    client = securitycenter.SecurityCenterClient()
-
-    # 'source_name' is the resource path for a source that has been
-    # created previously (you can use list_sources to find a specific one).
-    # Its format is:
-    # source_name = "{parent}/sources/{source_id}"
-    # 'parent' must be in one of the following formats:
-    #   "organizations/{organization_id}"
-    #   "projects/{project_id}"
-    #   "folders/{folder_id}"
-    # source_name = "organizations/111122222444/sources/1234"
-
-    # Group findings as of yesterday.
-    read_time = datetime.utcnow() - timedelta(days=1)
-
-    group_result_iterator = client.group_findings(
-        request={"parent": source_name, "group_by": "category", "read_time": read_time}
-    )
-    for i, group_result in enumerate(group_result_iterator):
-        print((i + 1), group_result)
-    # [END securitycenter_group_findings_at_time]
-    return i
-
-
-def group_findings_and_changes(source_name):
-    """Demonstrates grouping all findings across an organization and
-    associated changes."""
-    i = 0
-    # [START securitycenter_group_findings_with_changes]
-    from datetime import timedelta
-
-    from google.cloud import securitycenter
-
-    # Create a client.
-    client = securitycenter.SecurityCenterClient()
-
-    # 'source_name' is the resource path for a source that has been
-    # created previously (you can use list_sources to find a specific one).
-    # Its format is:
-    # source_name = "{parent}/sources/{source_id}"
-    # 'parent' must be in one of the following formats:
-    #   "organizations/{organization_id}"
-    #   "projects/{project_id}"
-    #   "folders/{folder_id}"
-    # source_name = "organizations/111122222444/sources/1234"
-
-    # List assets and their state change the last 30 days
-    compare_delta = timedelta(days=30)
-
-    group_result_iterator = client.group_findings(
-        request={
-            "parent": source_name,
-            "group_by": "state_change",
-            "compare_duration": compare_delta,
-        }
-    )
-    for i, group_result in enumerate(group_result_iterator):
-        print((i + 1), group_result)
-    # [END securitycenter_group_findings_with_changes]]
-    return i