Skip to content

Commit 9dc7267

Browse files
authored
Change what we do with manually triggered dag_runs to being pruned too. (#13480)
* Change what we do with manualy triggered dag_runs to being pruned too. * Fix lint.
1 parent 3cee180 commit 9dc7267

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

composer/workflows/airflow_db_cleanup.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
from airflow.version import version as airflow_version
6767

6868
import dateutil.parser
69-
from sqlalchemy import desc, sql, text
69+
from sqlalchemy import desc, text
7070
from sqlalchemy.exc import ProgrammingError
7171

7272

@@ -364,8 +364,6 @@ def build_query(
364364
query = query.filter(airflow_db_model.dag_id == dag_id)
365365

366366
if airflow_db_model == DagRun:
367-
# For DagRuns we want to leave last *scheduled* DagRun
368-
# regardless of its age
369367
newest_dagrun = (
370368
session
371369
.query(airflow_db_model)
@@ -375,17 +373,16 @@ def build_query(
375373
.first()
376374
)
377375
logging.info("Newest dagrun: " + str(newest_dagrun))
376+
377+
# For DagRuns we want to leave last *scheduled* DagRun
378+
# regardless of its age, otherwise Airflow will retrigger it
378379
if newest_dagrun is not None:
379380
query = (
380381
query
381-
.filter(age_check_column <= max_date)
382382
.filter(airflow_db_model.id != newest_dagrun.id)
383383
)
384-
else:
385-
query = query.filter(sql.false())
386-
else:
387-
query = query.filter(age_check_column <= max_date)
388384

385+
query = query.filter(age_check_column <= max_date)
389386
logging.info("FINAL QUERY: " + str(query))
390387

391388
return query

0 commit comments

Comments
 (0)