Skip to content

Commit 6618381

Browse files
iennaeglasnt
andauthored
fix(secretmanager): clean up some issues with create_secret (#13429)
* fix(secretmanager): clean up some issues with create_secret * arguments make this required in running, but the function says optional * remove duplicate import * fix: resolve error with importing in the wrong place * apply black on file --------- Co-authored-by: Katie McLaughlin <katie@glasnt.com>
1 parent 4952365 commit 6618381

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

secretmanager/snippets/create_secret.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@
1919
import argparse
2020
from typing import Optional
2121

22+
# [START secretmanager_create_secret]
23+
# Import the Secret Manager client library.
2224
from google.cloud import secretmanager
2325

2426

25-
# [START secretmanager_create_secret]
2627
def create_secret(
2728
project_id: str, secret_id: str, ttl: Optional[str] = None
2829
) -> secretmanager.Secret:
@@ -50,9 +51,6 @@ def create_secret(
5051
new_secret_with_ttl = create_secret("my-project", "my-timed-secret", "7776000s")
5152
"""
5253

53-
# Import the Secret Manager client library.
54-
from google.cloud import secretmanager
55-
5654
# Create the Secret Manager client.
5755
client = secretmanager.SecretManagerServiceClient()
5856

@@ -81,7 +79,7 @@ def create_secret(
8179
)
8280
parser.add_argument("project_id", help="id of the GCP project")
8381
parser.add_argument("secret_id", help="id of the secret to create")
84-
parser.add_argument("ttl", help="time to live for secrets, f.e. '600s' ")
82+
parser.add_argument("--ttl", help="time to live for secrets, f.e. '600s' ")
8583
args = parser.parse_args()
8684

8785
create_secret(args.project_id, args.secret_id, args.ttl)

0 commit comments

Comments
 (0)