Skip to content

Commit 5698567

Browse files
test(secretmanager): add test_create_secret_without_ttl (#13243)
* test(secretmanager): add test test_create_secret_without_ttl * test(secretmanager): make a simple change to trigger GitHub Actions again * test(secretmanager): revert previous commit
1 parent 7eef5e3 commit 5698567

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

secretmanager/snippets/snippets_test.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,13 +232,24 @@ def test_add_secret_version(secret: Tuple[str, str, str]) -> None:
232232

233233

234234
def test_create_secret(
235-
client: secretmanager.SecretManagerServiceClient,
236235
project_id: str,
237236
secret_id: str,
238237
ttl: Optional[str],
239238
) -> None:
240239
secret = create_secret(project_id, secret_id, ttl)
240+
241+
assert secret_id in secret.name
242+
assert secret.expire_time
243+
244+
245+
def test_create_secret_without_ttl(
246+
project_id: str,
247+
secret_id: str,
248+
) -> None:
249+
secret = create_secret(project_id, secret_id, None)
250+
241251
assert secret_id in secret.name
252+
assert not secret.expire_time
242253

243254

244255
def test_create_secret_with_user_managed_replication(

0 commit comments

Comments
 (0)