add linter

Author: davidcavazos

.github/testing/package.json

@@ -8,6 +8,7 @@
     "lint": "gts lint",
     "fix": "gts fix",
     "affected": "bun run ./src/main.ts affected",
+    "linter": "bun run ./src/main.ts linter",
     "tests": "bun run ./src/main.ts tests"
   },
   "dependencies": {

.github/testing/src/config.ts

@@ -15,16 +15,16 @@
 import * as fs from 'node:fs';
 import * as git from './git';
 import * as path from 'path';
-import {List, Map, Set} from 'immutable';
-import {minimatch} from 'minimatch'; /* eslint-disable @typescript-eslint/no-explicit-any */
-import {Affected, TestAll, TestName, TestPath, mergeAffected} from './affected';
+import { List, Map, Set } from 'immutable';
+import { minimatch } from 'minimatch'; /* eslint-disable @typescript-eslint/no-explicit-any */
+import { Affected, TestAll, TestName, TestPath, mergeAffected } from './affected';
 
-type RunTestsAll = {
+type Args = {
   root: string;
   path: string;
 };
 
-type RunTestsSome = {
+type ArgsTestSome = {
   root: string;
   path: string;
   tests: Map<TestPath, Set<TestName>>;
@@ -36,27 +36,31 @@ export class Config {
   match: List<string>;
   ignore: List<string>;
   packageFile: List<string>;
-  testAll: (_: RunTestsAll) => void;
-  testSome: (_: RunTestsSome) => void;
+  _lint: (_: Args) => void;
+  _testAll: (_: Args) => void;
+  _testSome: (_: ArgsTestSome) => void;
 
   constructor({
     match,
     ignore,
     packageFile,
+    lint,
     testAll,
     testSome,
   }: {
     match?: string[];
     ignore?: string[];
     packageFile?: string[];
-    testAll?: (_: RunTestsAll) => void;
-    testSome?: (_: RunTestsSome) => void;
+    lint?: (_: Args) => void;
+    testAll?: (_: Args) => void;
+    testSome?: (_: ArgsTestSome) => void;
   }) {
     this.match = List(match || ['**']);
     this.ignore = List(ignore);
     this.packageFile = List(packageFile);
-    this.testAll = testAll || (_ => {});
-    this.testSome = testSome || (_ => {});
+    this._lint = lint || (_ => { });
+    this._testAll = testAll || (_ => { });
+    this._testSome = testSome || (_ => { });
   }
 
   affected = (head: string, main: string): List<Affected> =>
@@ -71,17 +75,27 @@ export class Config {
         .values()
     );
 
+  lint = (affected: Affected) => {
+    const cwd = process.cwd();
+    const root = git.root();
+    const dir = path.join(root, affected.path);
+    console.log(`> cd ${dir}`);
+    process.chdir(dir);
+    this._lint({ root: root, path: affected.path });
+    process.chdir(cwd);
+  };
+
   test = (affected: Affected) => {
     const cwd = process.cwd();
     const root = git.root();
     const dir = path.join(root, affected.path);
     console.log(`> cd ${dir}`);
     process.chdir(dir);
     if ('TestAll' in affected) {
-      this.testAll({root: root, path: affected.path});
+      this._testAll({ root: root, path: affected.path });
     }
     if ('TestSome' in affected) {
-      this.testSome({
+      this._testSome({
         root: root,
         path: affected.path,
         tests: affected.TestSome,

.github/testing/src/config/python.ts

@@ -14,7 +14,7 @@
 
 import * as path from 'path';
 import * as subprocess from '../subprocess';
-import {Config} from '../config';
+import { Config } from '../config';
 
 export const python = (version = '3.11') =>
   new Config({
@@ -27,6 +27,11 @@ export const python = (version = '3.11') =>
       'setup.py',
       'setup.cfg',
     ],
+    lint: args => {
+      const noxfile = path.join(args.root, 'noxfile-template.py');
+      subprocess.run('cp', [noxfile, 'noxfile.py']);
+      subprocess.run('nox', ['-s', 'lint']);
+    },
     testAll: args => {
       const noxfile = path.join(args.root, 'noxfile-template.py');
       subprocess.run('cp', [noxfile, 'noxfile.py']);

.github/testing/src/main.ts

@@ -44,6 +44,12 @@ function main(command: string) {
       console.log(JSON.stringify(affected));
       return;
     }
+    case 'linter': {
+      const config = getConfig(process.argv[3]);
+      const affected: Affected = JSON.parse(process.env[process.argv[4]] || '');
+      config.lint(affected);
+      return;
+    }
     case 'tests': {
       const config = getConfig(process.argv[3]);
       const affected: Affected = JSON.parse(process.env[process.argv[4]] || '');

.github/workflows/test.yaml

@@ -45,8 +45,30 @@ jobs:
           echo "$AFFECTED_PYTHON"
           echo "affected=$AFFECTED_PYTHON" >> "$GITHUB_OUTPUT"
 
+  python-lint:
+    name: Lint Python
+    needs: affected
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        affected: ${{fromJson(needs.affected.outputs.python)}}
+    defaults:
+      run:
+        working-directory: .github/testing
+    steps:
+      - uses: actions/checkout@v4
+      - uses: oven-sh/setup-bun@v2
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.12'
+      - run: pip install nox
+      - run: bun install
+      - run: bun run linter python AFFECTED
+        env:
+          AFFECTED: ${{toJson(matrix.affected)}}
+
   python-test:
-    name: Test Python ${{matrix.python-version}}
+    name: Test Python
     needs: affected
     runs-on: ubuntu-latest
     strategy: