From 1163b80856c00227a55d97eda37c56f2d976a1a8 Mon Sep 17 00:00:00 2001 From: Eric Schmidt Date: Tue, 18 Mar 2025 12:17:46 -0700 Subject: [PATCH 1/2] fix: sets ServiceAccountTests in IAM package to Ignore --- .../src/test/java/ServiceAccountTests.java | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/iam/snippets/src/test/java/ServiceAccountTests.java b/iam/snippets/src/test/java/ServiceAccountTests.java index 9d612bf3d98..99b346e14b4 100644 --- a/iam/snippets/src/test/java/ServiceAccountTests.java +++ b/iam/snippets/src/test/java/ServiceAccountTests.java @@ -34,6 +34,7 @@ import org.junit.Before; import org.junit.BeforeClass; import org.junit.FixMethodOrder; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.runner.RunWith; @@ -77,6 +78,7 @@ public void tearDown() { bout.reset(); } + @Ignore("issue #10041") @Test public void stage1_testServiceAccountCreate() throws IOException { ServiceAccount serviceAccount = CreateServiceAccount @@ -88,6 +90,7 @@ public void stage1_testServiceAccountCreate() throws IOException { } + @Ignore("issue #10041") @Test public void stage1_testServiceAccountsList() throws IOException { IAMClient.ListServiceAccountsPagedResponse response = @@ -96,6 +99,7 @@ public void stage1_testServiceAccountsList() throws IOException { assertTrue(response.iterateAll().iterator().hasNext()); } + @Ignore("issue #10041") @Test public void stage2_testServiceAccountRename() throws IOException { String renameTo = "your-new-display-name"; @@ -108,6 +112,7 @@ public void stage2_testServiceAccountRename() throws IOException { assertThat(renameTo, containsString(serviceAccount.getDisplayName())); } + @Ignore("issue #10041") @Test public void stage2_testServiceAccountGet() throws IOException { ServiceAccount account = GetServiceAccount.getServiceAccount(PROJECT_ID, SERVICE_ACCOUNT); @@ -116,6 +121,7 @@ public void stage2_testServiceAccountGet() throws IOException { assertEquals(PROJECT_ID, account.getProjectId()); } + @Ignore("issue #10041") @Test public void stage2_testServiceAccountKeyCreate() throws IOException { ServiceAccountKey key = CreateServiceAccountKey.createKey(PROJECT_ID, SERVICE_ACCOUNT); @@ -126,6 +132,7 @@ public void stage2_testServiceAccountKeyCreate() throws IOException { assertNotNull(SERVICE_ACCOUNT_KEY_ID); } + @Ignore("issue #10041") @Test public void stage2_testServiceAccountKeyGet() throws IOException { ServiceAccountKey key = GetServiceAccountKey @@ -136,6 +143,7 @@ public void stage2_testServiceAccountKeyGet() throws IOException { assertTrue(key.getName().contains(SERVICE_ACCOUNT)); } + @Ignore("issue #10041") @Test public void stage2_testServiceAccountKeysList() throws IOException { List keys = ListServiceAccountKeys.listKeys(PROJECT_ID, SERVICE_ACCOUNT); @@ -146,6 +154,7 @@ public void stage2_testServiceAccountKeysList() throws IOException { .anyMatch(keyName -> keyName.contains(SERVICE_ACCOUNT_KEY_ID))); } + @Ignore("issue #10041") @Test public void stage2_testServiceAccountKeyDisable() throws IOException { DisableServiceAccountKey @@ -157,6 +166,7 @@ public void stage2_testServiceAccountKeyDisable() throws IOException { assertTrue(key.getDisabled()); } + @Ignore("issue #10041") @Test public void stage2_testServiceAccountKeyEnable() throws IOException { EnableServiceAccountKey @@ -168,6 +178,7 @@ public void stage2_testServiceAccountKeyEnable() throws IOException { assertFalse(key.getDisabled()); } + @Ignore("issue #10041") @Test public void stage3_testServiceAccountKeyDelete() throws IOException { DeleteServiceAccountKey.deleteKey(PROJECT_ID, SERVICE_ACCOUNT, SERVICE_ACCOUNT_KEY_ID); @@ -180,6 +191,7 @@ public void stage3_testServiceAccountKeyDelete() throws IOException { assertThat(got, !containsString(SERVICE_ACCOUNT_KEY_ID).matches(got)); } + @Ignore("issue #10041") @Test public void stage4_testDisableServiceAccount() throws IOException { DisableServiceAccount.disableServiceAccount(PROJECT_ID, SERVICE_ACCOUNT); @@ -191,6 +203,7 @@ public void stage4_testDisableServiceAccount() throws IOException { assertTrue(SERVICE_ACCOUNT, serviceAccount.getDisabled()); } + @Ignore("issue #10041") @Test public void stage5_testEnableServiceAccount() throws IOException { EnableServiceAccount.enableServiceAccount(PROJECT_ID, SERVICE_ACCOUNT); @@ -202,6 +215,7 @@ public void stage5_testEnableServiceAccount() throws IOException { assertFalse(SERVICE_ACCOUNT, serviceAccount.getDisabled()); } + @Ignore("issue #10041") @Test public void stage6_testServiceAccountDelete() throws IOException { DeleteServiceAccount.deleteServiceAccount(PROJECT_ID, SERVICE_ACCOUNT); From 390f00832f2bce4e92f41d47ea26ed694486107c Mon Sep 17 00:00:00 2001 From: Eric Schmidt Date: Tue, 18 Mar 2025 12:29:26 -0700 Subject: [PATCH 2/2] more tests to skip --- iam/snippets/src/test/java/QuickstartTests.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/iam/snippets/src/test/java/QuickstartTests.java b/iam/snippets/src/test/java/QuickstartTests.java index 22ae8dc2858..56c58ef71ca 100644 --- a/iam/snippets/src/test/java/QuickstartTests.java +++ b/iam/snippets/src/test/java/QuickstartTests.java @@ -32,6 +32,7 @@ import org.junit.After; import org.junit.Before; import org.junit.BeforeClass; +import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @@ -87,6 +88,7 @@ public void tearDown() throws IOException { } } + @Ignore("issue #10041") @Test public void testQuickstart() throws Exception { String member = "serviceAccount:" + serviceAccountEmail;