Skip to content

Commit 6fd7142

Browse files
Update RemoveMember.java comments
Includes changing "member" to "principal" and linking to principal identifiers page instead of specifying recommended format.
1 parent 7819113 commit 6fd7142

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

iam/snippets/src/main/java/RemoveMember.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,14 @@ public static void main(String[] args) throws IOException {
2727
Policy policy = Policy.newBuilder().build();
2828
// TODO: Replace with your role.
2929
String role = "roles/existing-role";
30-
// TODO: Replace with your member.
31-
String member = "user:member-to-add@example.com";
30+
// TODO: Replace with your principal.
31+
// For examples, see https://cloud.google.com/iam/docs/principal-identifiers
32+
String member = "principal-id";
3233

3334
removeMember(policy, role, member);
3435
}
3536

36-
// Removes member from a role; removes binding if binding contains no members.
37+
// Removes principal from a role; removes binding if binding contains no members.
3738
public static Policy removeMember(Policy policy, String role, String member) {
3839
// Creating new builder with all values copied from origin policy
3940
Policy.Builder policyBuilder = policy.toBuilder();
@@ -49,12 +50,12 @@ public static Policy removeMember(Policy policy, String role, String member) {
4950

5051
if (binding != null && binding.getMembersList().contains(member)) {
5152
List<String> newMemberList = new ArrayList<>(binding.getMembersList());
52-
// Removing member from a role
53+
// Removing principal from the role
5354
newMemberList.remove(member);
5455

5556
System.out.println("Member " + member + " removed from " + role);
5657

57-
// Adding all remaining members to create new binding
58+
// Adding all remaining principals to create new binding
5859
Binding newBinding = binding.toBuilder()
5960
.clearMembers()
6061
.addAllMembers(newMemberList)
@@ -70,14 +71,14 @@ public static Policy removeMember(Policy policy, String role, String member) {
7071
newBindingList.add(newBinding);
7172
}
7273

73-
// Update the policy to remove the member.
74+
// Update the policy to remove the principal.
7475
policyBuilder.clearBindings()
7576
.addAllBindings(newBindingList);
7677
}
7778

7879
Policy updatedPolicy = policyBuilder.build();
7980

80-
System.out.println("Exising members: " + updatedPolicy.getBindingsList());
81+
System.out.println("Exising principals: " + updatedPolicy.getBindingsList());
8182

8283
return updatedPolicy;
8384
}

0 commit comments

Comments
 (0)