Thank you and Feedback

[pbel78]

Hi GooRoo.

Thank you. Your plugin solves already a big issue resolving the links and images.

There is already a plugin for call outs and comments: maybe you can have look there instead of reinventing (I use both plugins now in parallel: https://github.com/ndy2/mkdocs-obsidian-support-plugin (or maybe just reference to the other plugin?)

The last thing I'm missing is included pages: converting ![[x]] to --8<-- "x.md"

So it can be used with
markdown_extensions:

• pymdownx.snippets

Would that be a big thing to add as you have already the right logic in there to resolve the correct documents?

Regards
Petr

[GooRoo]

Hi Petr,

Thank you for kind words!
It would probably make sense to not reinvent the wheel with callouts, but since I have already done that and callouts are already supported by my plugin too, I don't see much sense in undoing that 🙂

I was looking into page embedding a couple of weeks ago, and it seems doable. Although I wasn't sure whether anyone uses this feature at all. You confirmed that you do, so I'll try implementing it.

[pbel78]

Hi

No please don't undo functionality :)

I just gave it a quick try by copying and adapting your logic:

I worked but it is probably not the best quality code as I'm not a Pyhton developer. Also the integration of the pages works for me only from a fixed directory as relative paths didn't worked. So I have added this to my config and did put the includes all in the same folder

docs/includes:

mkdocs.yaml

markdown_extensions:
- pymdownx.snippets:
    base_path:
      - docs/includes

plugin.py

  def process_obsidian_embeds(self, page_path: Path, markdown: str) -> str:
         print("****************************    obsidian embed processing was calld")

         def process_chunk(index: int, chunk: str) -> str:
             EMBED_LINK = r'!\[\[(?P<filepath>[^\]#\|]+)(?P<fragment>\#[^\|\]]+)?(?:\|(?P<label>[^\]]*))?\]\]'
             print(index % 3)
             if index % 3 == 0:  # regular text
                if chunk.startswith("## Module Jobs"):
                     print(f"Processing chunk {index} (full): {chunk}")
                return re.sub(
                     EMBED_LINK,
                     partial(self.replace_obsidian_embed, page_path),
                     chunk,
                 )
             else:
                 print("not processing this chunk")
                 return chunk  # code blocks or backticks untouched

         assert page_path.is_absolute()

         CODE_BLOCK = re.compile(r'((`+).+?\2|<pre>.+?</pre>|<code>.+?</code>)', re.DOTALL)
         raw_chunks = re.split(CODE_BLOCK, markdown)

         processed_chunks = [
             process_chunk(i, c)
             for i, c in enumerate(raw_chunks)
             if i % 3 != 2  # skip backtick count chunks
         ]

         return ''.join(processed_chunks)

 def replace_obsidian_embed(self, page_path: Path, match: re.Match) -> str:
     assert page_path.is_absolute()
     IMAGE_EXTS = {'.png', '.jpg', '.jpeg', '.gif', '.bmp', '.svg', '.webp', '.avif'}

     raw = match['filepath'].strip()
     fragment = (match['fragment'] or '').lstrip('#')  # not used for now
     label = (match['label'] or '').strip()

     link_filepath = Path(raw.replace('\\', '/'))

     # Try to resolve: if no extension, prefer .md first (Obsidian behavior)
     candidates: list[Path] = []
     if link_filepath.suffix == "":
         candidates.append(link_filepath.with_suffix(".md"))
         candidates.append(link_filepath)
     else:
         candidates.append(link_filepath)

     new_path: Path | None = None
     for cand in candidates:
         new_path = self.find_best_path(cand, page_path)
         if new_path is not None:
             break

     # If nothing resolved, fall back to the original token
     final_path: Path = new_path or link_filepath

     # Decide by extension
     ext = final_path.suffix.lower()

     # --- IMAGES: emit a normal Markdown image, do NOT wrap in snippets ---
     if ext in IMAGE_EXTS:
         alt = label or final_path.stem
         url = urllib.parse.quote(final_path.as_posix())
         out = f"![{alt}]({url})"
         logger.debug("[ObsidianBridge] Embed Image: %s ==> %s", match[0], out)
         return out

     # --- NON-IMAGES: emit a snippets include (keep directories!) ---
     if final_path.suffix == "":
         # default to .md for bare names
         final_path = final_path.with_suffix(".md")

     include_target = final_path.as_posix()  # keep subfolders
     include_line = f'--8<-- "{include_target}"'

     if fragment:
         logger.debug("[ObsidianBridge] Ignoring fragment on embed: %s#%s", raw, fragment)

     logger.debug("[ObsidianBridge] Embed Replace: %s ==> %s", match[0], include_line)
     # If unresolved, annotate via with_attrs so you can style it (optional)
     return self.with_attrs(include_line, when=new_path is None)