Skip to content

Commit 48c0c2d

Browse files
committed
Clarify messages
This is mainly to avoid the effect of specifically recommending that the release version/name (usually taken from a tag) be changed to match the version in Cargo.toml, which would not always be good advice because it may be that the version in Cargo.toml is wrong, or that both are wrong, or in testing that a specially named tag (or `VERSION` environment variable) should be used.
1 parent 9041e36 commit 48c0c2d

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,19 @@ jobs:
4545
4646
case "$VERSION" in
4747
"v$manifest_version" )
48-
echo 'OK: Version to name the relase agrees with top-level Cargo.toml.'
48+
echo 'OK: Release name/version agrees with Cargo.toml version.'
4949
;;
5050
TEST-* | *-DO-NOT-USE )
51-
echo 'OK: Version to name the release is strange but marked as such.'
51+
echo 'OK: Release name/version is strange but marked as such.'
5252
;;
5353
"$manifest_version" )
54-
echo 'STOPPING: Version to name the release is missing the leading "v".'
54+
echo 'STOPPING: Release name/version is missing the leading "v".'
5555
exit 1
5656
;;
5757
* )
58-
echo 'STOPPING: Version to name the release seems mistaken.'
58+
echo 'STOPPING: Release name/version and Cargo.toml version do not match.'
59+
echo 'STOPPING: Usually this means either a wrong tag name or wrong version in Cargo.toml.'
60+
echo 'STOPPING: If intended, prepend `TEST-` or append `-DO-NOT-USE` to the release name.'
5961
exit 1
6062
;;
6163
esac

0 commit comments

Comments
 (0)