refactor

- fix typo
- move and simplify test; minimize its fixture
- adjust docs

Author: Byron

gix-features/src/fs.rs

@@ -208,9 +208,12 @@ pub mod walkdir {
     ///
     /// Use `precompose_unicode` to represent the `core.precomposeUnicode` configuration option.
     /// Use `max_depth` to limit the depth of the recursive walk.
-    ///   * 0 -> Returns only the root path with no children
-    ///   * 1 -> Root directory and children.
-    ///   * 2..n -> Root directory, children and {n}-grandchildren
+    ///   * `0`
+    ///       - Returns only the root path with no children
+    ///   * `1`
+    ///       - Root directory and children.
+    ///   * `1..n`
+    ///       - Root directory, children and {n}-grandchildren
     pub fn walkdir_sorted_new(root: &Path, _: Parallelism, max_depth: usize, precompose_unicode: bool) -> WalkDir {
         WalkDir {
             inner: WalkDirImpl::new(root)

gix-ref/src/store/file/loose/iter.rs

@@ -22,10 +22,9 @@ impl SortedLoosePaths {
         base: PathBuf,
         prefix: Option<BString>,
         suffix: Option<BString>,
-        root_only: bool,
         precompose_unicode: bool,
     ) -> Self {
-        let depth = if root_only { 1 } else { usize::MAX };
+        let depth = if suffix.is_some() { 1 } else { usize::MAX };
         SortedLoosePaths {
             base,
             prefix,

gix-ref/src/store/file/overlay_iter.rs

@@ -1,3 +1,5 @@
+use gix_object::bstr::ByteSlice;
+use gix_path::RelativePath;
 use std::{
     borrow::Cow,
     cmp::Ordering,
@@ -6,9 +8,6 @@ use std::{
     path::{Path, PathBuf},
 };
 
-use gix_object::bstr::ByteSlice;
-use gix_path::RelativePath;
-
 use crate::{
     file::loose::{self, iter::SortedLoosePaths},
     store_impl::{file, packed},
@@ -85,46 +84,40 @@ impl<'p> LooseThenPacked<'p, '_> {
     }
 
     fn convert_loose(&mut self, res: std::io::Result<(PathBuf, FullName)>) -> Result<Reference, Error> {
-        convert_loose(&mut self.buf, self.git_dir, self.common_dir, self.namespace, res)
-    }
-}
-
-pub(crate) fn convert_loose(
-    buf: &mut Vec<u8>,
-    git_dir: &Path,
-    common_dir: Option<&Path>,
-    namespace: Option<&Namespace>,
-    res: std::io::Result<(PathBuf, FullName)>,
-) -> Result<Reference, Error> {
-    let (refpath, name) = res.map_err(Error::Traversal)?;
-    std::fs::File::open(&refpath)
-        .and_then(|mut f| {
-            buf.clear();
-            f.read_to_end(buf)
-        })
-        .map_err(|err| Error::ReadFileContents {
-            source: err,
-            path: refpath.to_owned(),
-        })?;
-    loose::Reference::try_from_path(name, buf)
-        .map_err(|err| {
-            let relative_path = refpath
-                .strip_prefix(git_dir)
-                .ok()
-                .or_else(|| common_dir.and_then(|common_dir| refpath.strip_prefix(common_dir).ok()))
-                .expect("one of our bases contains the path");
-            Error::ReferenceCreation {
+        let buf = &mut self.buf;
+        let git_dir = self.git_dir;
+        let common_dir = self.common_dir;
+        let namespace = self.namespace;
+        let (refpath, name) = res.map_err(Error::Traversal)?;
+        std::fs::File::open(&refpath)
+            .and_then(|mut f| {
+                buf.clear();
+                f.read_to_end(buf)
+            })
+            .map_err(|err| Error::ReadFileContents {
                 source: err,
-                relative_path: relative_path.into(),
-            }
-        })
-        .map(Into::into)
-        .map(|mut r: Reference| {
-            if let Some(namespace) = namespace {
-                r.strip_namespace(namespace);
-            }
-            r
-        })
+                path: refpath.to_owned(),
+            })?;
+        loose::Reference::try_from_path(name, buf)
+            .map_err(|err| {
+                let relative_path = refpath
+                    .strip_prefix(git_dir)
+                    .ok()
+                    .or_else(|| common_dir.and_then(|common_dir| refpath.strip_prefix(common_dir).ok()))
+                    .expect("one of our bases contains the path");
+                Error::ReferenceCreation {
+                    source: err,
+                    relative_path: relative_path.into(),
+                }
+            })
+            .map(Into::into)
+            .map(|mut r: Reference| {
+                if let Some(namespace) = namespace {
+                    r.strip_namespace(namespace);
+                }
+                r
+            })
+    }
 }
 
 impl Iterator for LooseThenPacked<'_, '_> {
@@ -203,9 +196,9 @@ impl Iterator for LooseThenPacked<'_, '_> {
 }
 
 impl Platform<'_> {
-    /// Return an iterator over all references, loose or `packed`, sorted by their name.
+    /// Return an iterator over all references, loose or packed, sorted by their name.
     ///
-    /// Errors are returned similarly to what would happen when loose and packed refs where iterated by themselves.
+    /// Errors are returned similarly to what would happen when loose and packed refs were iterated by themselves.
     pub fn all(&self) -> std::io::Result<LooseThenPacked<'_, '_>> {
         self.store.iter_packed(self.packed.as_ref().map(|b| &***b))
     }
@@ -224,15 +217,15 @@ impl Platform<'_> {
     }
 
     /// Return an iterator over the pseudo references
-    pub fn psuedo_refs(&self) -> std::io::Result<LooseThenPacked<'_, '_>> {
-        self.store.iter_pseudo_refs()
+    pub fn pseudo_refs(&self) -> std::io::Result<LooseThenPacked<'_, '_>> {
+        self.store.iter_pseudo()
     }
 }
 
 impl file::Store {
     /// Return a platform to obtain iterator over all references, or prefixed ones, loose or packed, sorted by their name.
     ///
-    /// Errors are returned similarly to what would happen when loose and packed refs where iterated by themselves.
+    /// Errors are returned similarly to what would happen when loose and packed refs were iterated by themselves.
     ///
     /// Note that since packed-refs are storing refs as precomposed unicode if [`Self::precompose_unicode`] is true, for consistency
     /// we also return loose references as precomposed unicode.
@@ -271,7 +264,7 @@ pub(crate) enum IterInfo<'a> {
         /// If `true`, we will convert decomposed into precomposed unicode.
         precompose_unicode: bool,
     },
-    PseudoRefs {
+    Pseudo {
         base: &'a Path,
         precompose_unicode: bool,
     },
@@ -284,7 +277,7 @@ impl<'a> IterInfo<'a> {
             IterInfo::PrefixAndBase { prefix, .. } => Some(gix_path::into_bstr(*prefix)),
             IterInfo::BaseAndIterRoot { prefix, .. } => Some(gix_path::into_bstr(prefix.clone())),
             IterInfo::ComputedIterationRoot { prefix, .. } => Some(prefix.clone()),
-            IterInfo::PseudoRefs { .. } => None,
+            IterInfo::Pseudo { .. } => None,
         }
     }
 
@@ -293,18 +286,18 @@ impl<'a> IterInfo<'a> {
             IterInfo::Base {
                 base,
                 precompose_unicode,
-            } => SortedLoosePaths::at(&base.join("refs"), base.into(), None, None, false, precompose_unicode),
+            } => SortedLoosePaths::at(&base.join("refs"), base.into(), None, None, precompose_unicode),
             IterInfo::BaseAndIterRoot {
                 base,
                 iter_root,
                 prefix: _,
                 precompose_unicode,
-            } => SortedLoosePaths::at(&iter_root, base.into(), None, None, false, precompose_unicode),
+            } => SortedLoosePaths::at(&iter_root, base.into(), None, None, precompose_unicode),
             IterInfo::PrefixAndBase {
                 base,
                 prefix,
                 precompose_unicode,
-            } => SortedLoosePaths::at(&base.join(prefix), base.into(), None, None, false, precompose_unicode),
+            } => SortedLoosePaths::at(&base.join(prefix), base.into(), None, None, precompose_unicode),
             IterInfo::ComputedIterationRoot {
                 iter_root,
                 base,
@@ -315,13 +308,12 @@ impl<'a> IterInfo<'a> {
                 base.into(),
                 Some(prefix.into_owned()),
                 None,
-                false,
                 precompose_unicode,
             ),
-            IterInfo::PseudoRefs {
+            IterInfo::Pseudo {
                 base,
                 precompose_unicode,
-            } => SortedLoosePaths::at(base, base.into(), None, Some("HEAD".into()), true, precompose_unicode),
+            } => SortedLoosePaths::at(base, base.into(), None, Some("HEAD".into()), precompose_unicode),
         }
         .peekable()
     }
@@ -354,7 +346,7 @@ impl<'a> IterInfo<'a> {
 impl file::Store {
     /// Return an iterator over all references, loose or `packed`, sorted by their name.
     ///
-    /// Errors are returned similarly to what would happen when loose and packed refs where iterated by themselves.
+    /// Errors are returned similarly to what would happen when loose and packed refs were iterated by themselves.
     pub fn iter_packed<'s, 'p>(
         &'s self,
         packed: Option<&'p packed::Buffer>,
@@ -387,12 +379,12 @@ impl file::Store {
         }
     }
 
-    /// Return an iterator over all pseudo references, loose or `packed`, sorted by their name.
+    /// Return an iterator over all pseudo references, sorted by their name.
     ///
-    /// Errors are returned similarly to what would happen when loose and packed refs where iterated by themselves.
-    pub fn iter_pseudo_refs<'p>(&'_ self) -> std::io::Result<LooseThenPacked<'p, '_>> {
+    /// Errors are returned similarly to what would happen when loose refs were iterated by themselves.
+    pub fn iter_pseudo<'p>(&'_ self) -> std::io::Result<LooseThenPacked<'p, '_>> {
         self.iter_from_info(
-            IterInfo::PseudoRefs {
+            IterInfo::Pseudo {
                 base: self.git_dir(),
                 precompose_unicode: self.precompose_unicode,
             },

gix-ref/tests/fixtures/generated-archives/make_pref_repository.tar renamed to gix-ref/tests/fixtures/generated-archives/make_pseudo_ref_repository.tar

@@ -0,0 +1,14 @@
+#!/usr/bin/env bash
+set -eu -o pipefail
+
+git init -q
+git commit -m "init" --allow-empty
+
+git rev-parse HEAD > .git/JIRI_HEAD
+touch .git/SOME_ALL_CAPS_FILE
+touch .git/refs/SHOULD_BE_EXCLUDED_HEAD
+
+cat <<EOF >> .git/FETCH_HEAD
+9064ea31fae4dc59a56bdd3a06c0ddc990ee689e		branch 'main' of https://github.com/Byron/gitoxide
+1b8d9e6a408e480ae1912e919c37a26e5c46639d	not-for-merge	branch 'faster-discovery' of https://github.com/Byron/gitoxide
+EOF

gix-ref/tests/fixtures/make_pref_repository.sh

@@ -1,9 +1,8 @@
-use gix_object::bstr::ByteSlice;
-
 use crate::{
     file::{store, store_at, store_with_packed_refs},
     hex_to_id,
 };
+use gix_object::bstr::ByteSlice;
 
 mod with_namespace {
     use gix_object::bstr::{BString, ByteSlice};
@@ -257,6 +256,20 @@ fn packed_file_iter() -> crate::Result {
     Ok(())
 }
 
+#[test]
+fn pseudo_refs_iter() -> crate::Result {
+    let store = store_at("make_pseudo_ref_repository.sh")?;
+
+    let actual = store
+        .iter_pseudo()?
+        .map(Result::unwrap)
+        .map(|r: gix_ref::Reference| r.name.as_bstr().to_string())
+        .collect::<Vec<_>>();
+
+    assert_eq!(actual, ["FETCH_HEAD", "HEAD", "JIRI_HEAD"]);
+    Ok(())
+}
+
 #[test]
 fn loose_iter_with_broken_refs() -> crate::Result {
     let store = store()?;

gix-ref/tests/fixtures/make_pseudo_ref_repository.sh

@@ -39,7 +39,6 @@ mod partialname {
 }
 mod namespace;
 mod packed;
-mod pseudo_refs;
 mod reference;
 mod store;
 mod transaction;

gix-ref/tests/refs/file/store/iter.rs

@@ -72,8 +72,8 @@ impl Platform<'_> {
 
     // TODO: tests
     /// Return an iterator over all local pseudo references.
-    pub fn pseudo_refs(&self) -> Result<Iter<'_>, init::Error> {
-        Ok(Iter::new(self.repo, self.platform.psuedo_refs()?))
+    pub fn pseudo(&self) -> Result<Iter<'_>, init::Error> {
+        Ok(Iter::new(self.repo, self.platform.pseudo_refs()?))
     }
 
     // TODO: tests