You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This makes substantial changes to the release workflow, most of
them straightforwardly adapted from corresponding material in the
ripgrep release workflow:
- The biggest change is to use `gh` (the GitHub CLI) instead of
both the ncipollo/release-action and actions/upload-release-asset
actions.
- Use outputs instead of artifacts for the information that needs
to go from the `create-release` job into the `build-release`
jobs. This eliminates the need for actions/upload-artifact and
actions/download-artifact.
Furthermore, since `gh` doesn't require a URL to add files to an
existing release, there is only one output, the version.
- Split up the "Build archive" step so it doesn't need awkward
conditional logic inside a single script step. Now the platform
agnostic part of creating the directory and putting documentation
in it is one step, followed by steps with `if:` keys for Windows
and Unix.
For this, the main differences from how it is currently written
in the ripgrep workflow are the step titles, the uses of shell
expansion rather than `${{ }}` interpolation for the environment
variables, and the omission of checksum files since we are not
currently generating those.
This notably does not add either of the following to the workflow:
- This does not set `permissions:` for the workflow. It was not set
before, so the configuration, including in the upstream repo,
seems not to require it. (Note that this does not imply that the
configuration in the ripgrep repo doesn't require it.)
- This does try to do anything explicit to take the place of
specifying `omitBody: true` for ncipollo/release-action. I'm not
sure what should be done for this, but the current behavior seems
to produce the same result, and passing `--notes ''` to `gh`
might go too far. The current ripgrep workflow has no explicit
argument corresponding to this.
0 commit comments