Skip to content

Commit 212b618

Browse files
committed
add baseline tests for _ and @ in username
However, these don't show any differences as we already parsed these correctly, while the recent changes have been about serialization.
1 parent 04bc4a8 commit 212b618

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

gix-url/tests/fixtures/make_baseline.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ tests_windows=()
1515
for path in "repo" "re:po" "re/po"; do
1616
# normal urls
1717
for protocol in "ssh+git" "git+ssh" "git" "ssh"; do
18-
for host in "host" "user@host" "user@[::1]" "user@::1"; do
18+
for host in "host" "user@host" "user_name@host" "user@[::1]" "user@::1"; do
1919
for port_separator in "" ":"; do
2020
tests+=("$protocol://$host$port_separator/$path")
2121

@@ -42,7 +42,7 @@ for path in "repo" "re:po" "re/po"; do
4242
tests+=("./$protocol:$host/~$path")
4343
done
4444
# SCP like urls
45-
for host in "host" "[::1]"; do
45+
for host in "user@name@host" "user_name@host" "host" "[::1]"; do
4646
tests+=("$host:$path")
4747
tests+=("$host:/~$path")
4848
done

gix-url/tests/url/baseline.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ fn run() {
8484
}
8585

8686
assert!(
87-
failure_count_reserialization <= 42,
87+
failure_count_reserialization <= 63,
8888
"the number of reserialization errors should ideally get better, not worse - if this panic is not due to regressions but to new passing test cases, you can set this check to {failure_count_reserialization}"
8989
);
9090
assert_eq!(failure_count_roundtrips, 0, "there should be no roundtrip errors");
@@ -185,8 +185,8 @@ mod baseline {
185185

186186
pub fn max_num_failures(&self) -> usize {
187187
match self {
188-
Kind::Unix => 165,
189-
Kind::Windows => 171,
188+
Kind::Unix => 198,
189+
Kind::Windows => 198 + 6,
190190
}
191191
}
192192

0 commit comments

Comments
 (0)