Pass path parameter through decodeURIComponent

Author: SamyPesse

src/compileOperation.ts

@@ -64,7 +64,7 @@ export function compileOperation(
                                 const regexMatchIndex = getPathParamIndex(path, parameter.name);
 
                                 nodes.push(
-                                    builders.variableDeclaration('const', [
+                                    builders.variableDeclaration('let', [
                                         builders.variableDeclarator(
                                             identifier,
                                             builders.callExpression(schemaFn, [
@@ -83,6 +83,29 @@ export function compileOperation(
                                     ]),
                                 );
 
+                                // Path parameters should be decoded
+                                nodes.push(
+                                    builders.ifStatement(
+                                        builders.binaryExpression(
+                                            '==',
+                                            builders.unaryExpression('typeof', identifier, true),
+                                            builders.literal('string'),
+                                        ),
+                                        builders.blockStatement([
+                                            builders.expressionStatement(
+                                                builders.assignmentExpression(
+                                                    '=',
+                                                    identifier,
+                                                    builders.callExpression(
+                                                        builders.identifier('decodeURIComponent'),
+                                                        [identifier],
+                                                    ),
+                                                ),
+                                            ),
+                                        ]),
+                                    ),
+                                );
+
                                 // Return an error if the parameter is invalid
                                 nodes.push(
                                     builders.ifStatement(

tests/gitbook.test.ts

@@ -213,3 +213,21 @@ test('POST orgs/apple/members/jony (null)', () => {
         },
     });
 });
+
+test('GET spaces/space_iphone-doc/content/path/apps%2Fphone', () => {
+    const result = validateRequest({
+        path: '/spaces/space_iphone-doc/content/path/apps%2Fphone',
+        method: 'get',
+        headers: {
+            'content-type': 'application/json',
+        },
+        query: {},
+    });
+    expect(result).toMatchObject({
+        operationId: 'getPageByPath',
+        params: {
+            spaceId: 'space_iphone-doc',
+            pagePath: 'apps/phone',
+        },
+    });
+});