[Performance]Break async stream memory leaks #826

ipavlidakis · 2025-05-27T18:21:18Z

🎯 Goal

AsyncStreams are causing leaks on continuations. This revision attempts to fix that by backing AsyncStream on StreamVideo, by Combine Publishers

🧪 Manual Testing Notes

✅	Given	When	Then
🟠	In a call alone	I enable the camera	The camera has a flipping animation
🟠	In a call	I rotate the device	The app freezes and then kills the phone
🟠	In a call	I set a background filter	My video track gets stuck and I get disconnected, but UI is frozen
🟢	In a call with 4+ participants	I raise a hand	It does not show for me, but it does for web participants
🟠	In a call with >2 participants	I move app to background and then foreground	All video tracks appear frozen
🟠	In a call with >2 participants	I move app to background and then foreground	Camera and mic buttons do not work

✅ Call Test Summary

Scenario

1:1 call for 5 minutes

noise-cancellation: active
background-filter: inactive
profiler: connected
debugger: disconnected

🧵 Tasks

Created	Average Active	Average Alive
29309	3	13,000

🌡️ Thermal State Degradation

Start	End	Thermal State
00:00.000	00:55.710	Nominal thermal state
00:55.710	01:25.708	Fair thermal state
01:25.708	05:16.416	Serious thermal state

☑️ Contributor Checklist

I have signed the Stream CLA (required)
This change follows zero ⚠️ policy (required)
This change should receive manual QA
Changelog is updated with client-facing changes
New code is covered by unit tests
Comparison screenshots added for visual changes
Affected documentation updated (tutorial, CMS)

github-actions · 2025-05-27T18:35:48Z

Public Interface

+ extension ScreenPropertiesAdapter: InjectionKey  
+ 
+   public nonisolated static var currentValue: ScreenPropertiesAdapter

+ public final class ScreenPropertiesAdapter: @unchecked Sendable  
+ 
+   public private var preferredFramesPerSecond: Int
+   public private var refreshRate: TimeInterval
+   public private var scale: CGFloat

+ public protocol TimerProviding



 public class StreamVideo: ObservableObject, @unchecked Sendable  
-   public var state: State
+   case ringEventReceived
-   public let videoConfig: VideoConfig
+   
-   public var user: User
+ 
-   public var isHardwareAccelerationAvailable: Bool
+   public var state: State
-   public lazy var rejectionReasonProvider: RejectionReasonProviding
+   public let videoConfig: VideoConfig
-   
+   public var user: User
- 
+   public var isHardwareAccelerationAvailable: Bool
-   public convenience init(apiKey: String,user: User,token: UserToken,videoConfig: VideoConfig = VideoConfig(),pushNotificationsConfig: PushNotificationsConfig = .default,tokenProvider: UserTokenProvider? = nil)
+   public lazy var rejectionReasonProvider: RejectionReasonProviding
-   public func connect()async throws 
+   public convenience init(apiKey: String,user: User,token: UserToken,videoConfig: VideoConfig = VideoConfig(),pushNotificationsConfig: PushNotificationsConfig = .default,tokenProvider: UserTokenProvider? = nil)
-   public func call(callType: String,callId: String,callSettings: CallSettings? = nil)-> Call
+   
-   public func makeCallsController(callsQuery: CallsQuery)-> CallsController
+ 
-   @discardableResult public func setDevice(id: String)async throws -> ModelResponse
+   public func connect()async throws 
-   @discardableResult public func setVoipDevice(id: String)async throws -> ModelResponse
+   public func call(callType: String,callId: String,callSettings: CallSettings? = nil)-> Call
-   @discardableResult public func deleteDevice(id: String)async throws -> ModelResponse
+   public func makeCallsController(callsQuery: CallsQuery)-> CallsController
-   public func listDevices()async throws -> [Device]
+   @discardableResult public func setDevice(id: String)async throws -> ModelResponse
-   public func disconnect()async 
+   @discardableResult public func setVoipDevice(id: String)async throws -> ModelResponse
-   public func subscribe()-> AsyncStream<VideoEvent>
+   @discardableResult public func deleteDevice(id: String)async throws -> ModelResponse
-   public func subscribe(for event: WSEvent.Type)-> AsyncStream<WSEvent>
+   public func listDevices()async throws -> [Device]
-   public func queryCalls(next: String? = nil,watch: Bool = false)async throws -> (calls: [Call], next: String?)
+   public func disconnect()async 
-   public func queryCalls(filters: [String: RawJSON]?,sort: [SortParamRequest] = [SortParamRequest.descending("created_at")],limit: Int? = 25,watch: Bool = false)async throws -> (calls: [Call], next: String?)
+   public func eventPublisher()-> AnyPublisher<VideoEvent, Never>
-   
+   public func eventPublisher(for event: WSEvent.Type)-> AnyPublisher<WSEvent, Never>
- 
+   public func subscribe()-> AsyncStream<VideoEvent>
-   public final class State: ObservableObject, @unchecked Sendable  
+   public func subscribe(for event: WSEvent.Type)-> AsyncStream<WSEvent>
-   
+   public func queryCalls(next: String? = nil,watch: Bool = false)async throws -> (calls: [Call], next: String?)
-     @Published public internal var connection: ConnectionStatus
+   public func queryCalls(filters: [String: RawJSON]?,sort: [SortParamRequest] = [SortParamRequest.descending("created_at")],limit: Int? = 25,watch: Bool = false)async throws -> (calls: [Call], next: String?)
-     @Published public internal var user: User
+   
-     @Published public internal var activeCall: Call?
+ 
-     @Published public internal var ringingCall: Call?
+   public final class State: ObservableObject, @unchecked Sendable  
+   
+     @Published public internal var connection: ConnectionStatus
+     @Published public internal var user: User
+     @Published public internal var activeCall: Call?
+     @Published public internal var ringingCall: Call?

Stream-SDK-Bot · 2025-05-27T18:39:56Z

SDK Size

`title`	`develop`	`branch`	`diff`	`status`
StreamVideo	7.54 MB	7.54 MB	+3 KB	🟢
StreamVideoSwiftUI	2.26 MB	2.27 MB	+17 KB	🟢
StreamVideoUIKit	2.38 MB	2.39 MB	+16 KB	🟢
StreamWebRTC	9.85 MB	9.85 MB	0 KB	🟢

github-actions · 2025-05-27T19:08:50Z

Public Interface

+ extension ScreenPropertiesAdapter: InjectionKey  
+ 
+   public nonisolated static var currentValue: ScreenPropertiesAdapter

+ public final class ScreenPropertiesAdapter: @unchecked Sendable  
+ 
+   public private var preferredFramesPerSecond: Int
+   public private var refreshRate: TimeInterval
+   public private var scale: CGFloat

+ public protocol TimerProviding



 public class StreamVideo: ObservableObject, @unchecked Sendable  
-   public var state: State
+   case ringEventReceived
-   public let videoConfig: VideoConfig
+   
-   public var user: User
+ 
-   public var isHardwareAccelerationAvailable: Bool
+   public var state: State
-   public lazy var rejectionReasonProvider: RejectionReasonProviding
+   public let videoConfig: VideoConfig
-   
+   public var user: User
- 
+   public var isHardwareAccelerationAvailable: Bool
-   public convenience init(apiKey: String,user: User,token: UserToken,videoConfig: VideoConfig = VideoConfig(),pushNotificationsConfig: PushNotificationsConfig = .default,tokenProvider: UserTokenProvider? = nil)
+   public lazy var rejectionReasonProvider: RejectionReasonProviding
-   public func connect()async throws 
+   public convenience init(apiKey: String,user: User,token: UserToken,videoConfig: VideoConfig = VideoConfig(),pushNotificationsConfig: PushNotificationsConfig = .default,tokenProvider: UserTokenProvider? = nil)
-   public func call(callType: String,callId: String,callSettings: CallSettings? = nil)-> Call
+   
-   public func makeCallsController(callsQuery: CallsQuery)-> CallsController
+ 
-   @discardableResult public func setDevice(id: String)async throws -> ModelResponse
+   public func connect()async throws 
-   @discardableResult public func setVoipDevice(id: String)async throws -> ModelResponse
+   public func call(callType: String,callId: String,callSettings: CallSettings? = nil)-> Call
-   @discardableResult public func deleteDevice(id: String)async throws -> ModelResponse
+   public func makeCallsController(callsQuery: CallsQuery)-> CallsController
-   public func listDevices()async throws -> [Device]
+   @discardableResult public func setDevice(id: String)async throws -> ModelResponse
-   public func disconnect()async 
+   @discardableResult public func setVoipDevice(id: String)async throws -> ModelResponse
-   public func subscribe()-> AsyncStream<VideoEvent>
+   @discardableResult public func deleteDevice(id: String)async throws -> ModelResponse
-   public func subscribe(for event: WSEvent.Type)-> AsyncStream<WSEvent>
+   public func listDevices()async throws -> [Device]
-   public func queryCalls(next: String? = nil,watch: Bool = false)async throws -> (calls: [Call], next: String?)
+   public func disconnect()async 
-   public func queryCalls(filters: [String: RawJSON]?,sort: [SortParamRequest] = [SortParamRequest.descending("created_at")],limit: Int? = 25,watch: Bool = false)async throws -> (calls: [Call], next: String?)
+   public func eventPublisher()-> AnyPublisher<VideoEvent, Never>
-   
+   public func eventPublisher(for event: WSEvent.Type)-> AnyPublisher<WSEvent, Never>
- 
+   public func subscribe()-> AsyncStream<VideoEvent>
-   public final class State: ObservableObject, @unchecked Sendable  
+   public func subscribe(for event: WSEvent.Type)-> AsyncStream<WSEvent>
-   
+   public func queryCalls(next: String? = nil,watch: Bool = false)async throws -> (calls: [Call], next: String?)
-     @Published public internal var connection: ConnectionStatus
+   public func queryCalls(filters: [String: RawJSON]?,sort: [SortParamRequest] = [SortParamRequest.descending("created_at")],limit: Int? = 25,watch: Bool = false)async throws -> (calls: [Call], next: String?)
-     @Published public internal var user: User
+   
-     @Published public internal var activeCall: Call?
+ 
-     @Published public internal var ringingCall: Call?
+   public final class State: ObservableObject, @unchecked Sendable  
+   
+     @Published public internal var connection: ConnectionStatus
+     @Published public internal var user: User
+     @Published public internal var activeCall: Call?
+     @Published public internal var ringingCall: Call?

github-actions · 2025-05-27T22:26:07Z

Public Interface

+ extension ScreenPropertiesAdapter: InjectionKey  
+ 
+   public nonisolated static var currentValue: ScreenPropertiesAdapter

+ public final class ScreenPropertiesAdapter: @unchecked Sendable  
+ 
+   public private var preferredFramesPerSecond: Int
+   public private var refreshRate: TimeInterval
+   public private var scale: CGFloat

+ public protocol TimerProviding



 public class StreamVideo: ObservableObject, @unchecked Sendable  
-   public var state: State
+   case ringEventReceived
-   public let videoConfig: VideoConfig
+   
-   public var user: User
+ 
-   public var isHardwareAccelerationAvailable: Bool
+   public var state: State
-   public lazy var rejectionReasonProvider: RejectionReasonProviding
+   public let videoConfig: VideoConfig
-   
+   public var user: User
- 
+   public var isHardwareAccelerationAvailable: Bool
-   public convenience init(apiKey: String,user: User,token: UserToken,videoConfig: VideoConfig = VideoConfig(),pushNotificationsConfig: PushNotificationsConfig = .default,tokenProvider: UserTokenProvider? = nil)
+   public lazy var rejectionReasonProvider: RejectionReasonProviding
-   public func connect()async throws 
+   public convenience init(apiKey: String,user: User,token: UserToken,videoConfig: VideoConfig = VideoConfig(),pushNotificationsConfig: PushNotificationsConfig = .default,tokenProvider: UserTokenProvider? = nil)
-   public func call(callType: String,callId: String,callSettings: CallSettings? = nil)-> Call
+   
-   public func makeCallsController(callsQuery: CallsQuery)-> CallsController
+ 
-   @discardableResult public func setDevice(id: String)async throws -> ModelResponse
+   public func connect()async throws 
-   @discardableResult public func setVoipDevice(id: String)async throws -> ModelResponse
+   public func call(callType: String,callId: String,callSettings: CallSettings? = nil)-> Call
-   @discardableResult public func deleteDevice(id: String)async throws -> ModelResponse
+   public func makeCallsController(callsQuery: CallsQuery)-> CallsController
-   public func listDevices()async throws -> [Device]
+   @discardableResult public func setDevice(id: String)async throws -> ModelResponse
-   public func disconnect()async 
+   @discardableResult public func setVoipDevice(id: String)async throws -> ModelResponse
-   public func subscribe()-> AsyncStream<VideoEvent>
+   @discardableResult public func deleteDevice(id: String)async throws -> ModelResponse
-   public func subscribe(for event: WSEvent.Type)-> AsyncStream<WSEvent>
+   public func listDevices()async throws -> [Device]
-   public func queryCalls(next: String? = nil,watch: Bool = false)async throws -> (calls: [Call], next: String?)
+   public func disconnect()async 
-   public func queryCalls(filters: [String: RawJSON]?,sort: [SortParamRequest] = [SortParamRequest.descending("created_at")],limit: Int? = 25,watch: Bool = false)async throws -> (calls: [Call], next: String?)
+   public func eventPublisher()-> AnyPublisher<VideoEvent, Never>
-   
+   public func eventPublisher(for event: WSEvent.Type)-> AnyPublisher<WSEvent, Never>
- 
+   public func subscribe()-> AsyncStream<VideoEvent>
-   public final class State: ObservableObject, @unchecked Sendable  
+   public func subscribe(for event: WSEvent.Type)-> AsyncStream<WSEvent>
-   
+   public func queryCalls(next: String? = nil,watch: Bool = false)async throws -> (calls: [Call], next: String?)
-     @Published public internal var connection: ConnectionStatus
+   public func queryCalls(filters: [String: RawJSON]?,sort: [SortParamRequest] = [SortParamRequest.descending("created_at")],limit: Int? = 25,watch: Bool = false)async throws -> (calls: [Call], next: String?)
-     @Published public internal var user: User
+   
-     @Published public internal var activeCall: Call?
+ 
-     @Published public internal var ringingCall: Call?
+   public final class State: ObservableObject, @unchecked Sendable  
+   
+     @Published public internal var connection: ConnectionStatus
+     @Published public internal var user: User
+     @Published public internal var activeCall: Call?
+     @Published public internal var ringingCall: Call?

sonarqubecloud · 2025-05-27T22:41:38Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Enhancement]AsyncStreams are now backed by Publishers

917af32

ipavlidakis self-assigned this May 27, 2025

ipavlidakis added the enhancement New feature or request label May 27, 2025

ipavlidakis marked this pull request as ready for review May 27, 2025 18:21

ipavlidakis requested a review from a team as a code owner May 27, 2025 18:21

ipavlidakis changed the base branch from develop to fix/performance-improvements May 27, 2025 18:21

ipavlidakis changed the title ~~Fix/performance improvements subtasks/break async stream memory leaks~~ [Performance]Break async stream memory leaks May 27, 2025

ipavlidakis mentioned this pull request May 27, 2025

[Performance]Improvements #825

Draft

12 tasks

Fix failing tests

eaafa04

Remove subscriptions and make tests pass

646f982

ipavlidakis merged commit 56ad08e into fix/performance-improvements May 28, 2025
12 checks passed

ipavlidakis deleted the fix/performance-improvements-subtasks/break-async-stream-memory-leaks branch May 28, 2025 07:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Performance]Break async stream memory leaks #826

[Performance]Break async stream memory leaks #826

Uh oh!

ipavlidakis commented May 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

Stream-SDK-Bot commented May 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

sonarqubecloud bot commented May 27, 2025

Uh oh!

Uh oh!

Uh oh!

[Performance]Break async stream memory leaks #826

[Performance]Break async stream memory leaks #826

Uh oh!

Conversation

ipavlidakis commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Goal

🧪 Manual Testing Notes

✅ Call Test Summary

Scenario

🧵 Tasks

🌡️ Thermal State Degradation

☑️ Contributor Checklist

Uh oh!

github-actions bot commented May 27, 2025

Public Interface

Uh oh!

Stream-SDK-Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size

Uh oh!

github-actions bot commented May 27, 2025

Public Interface

Uh oh!

github-actions bot commented May 27, 2025

Public Interface

Uh oh!

sonarqubecloud bot commented May 27, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

ipavlidakis commented May 27, 2025 •

edited

Loading

Stream-SDK-Bot commented May 27, 2025 •

edited

Loading