[CI] Improve linters and git hooks

Author: testableapple

.github/workflows/cron-checks.yml

@@ -234,7 +234,7 @@ jobs:
     - uses: actions/checkout@v4.1.1
     - uses: ./.github/actions/bootstrap
     - run: bundle exec fastlane rubocop
-    - run: bundle exec fastlane run_swift_format lint:true
+    - run: bundle exec fastlane run_swift_format strict:true
     - run: bundle exec fastlane pod_lint
 
   slack:

.github/workflows/smoke-checks.yml

@@ -137,20 +137,13 @@ jobs:
     if: ${{ github.event.inputs.record_snapshots_swiftui != 'true' && github.event.inputs.record_snapshots_uikit != 'true' }}
     steps:
     - uses: actions/checkout@v4.1.1
-      with:
-        fetch-depth: 0
     - uses: ./.github/actions/bootstrap
-    - name: Public Interface Validation
-      run: bundle exec fastlane validate_public_interface
-    - name: Run Danger
-      run: bundle exec fastlane lint_pr
-    - name: Run Fastlane Linting
-      run: bundle exec fastlane rubocop
-    - name: Run SwiftFormat Linting
-      run: bundle exec fastlane run_swift_format lint:true
-    - name: Run Podspec Linting
+    - run: bundle exec fastlane validate_public_interface
+    - run: bundle exec fastlane lint_pr
+    - run: bundle exec fastlane rubocop
+    - run: bundle exec fastlane run_swift_format strict:true
+    - run: bundle exec fastlane pod_lint
       if: startsWith(github.event.pull_request.head.ref, 'release/')
-      run: bundle exec fastlane pod_lint
 
   build-xcode15:
     name: Build SDKs (Xcode 15)

Gemfile

@@ -7,6 +7,7 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 gem 'danger', group: :danger_dependencies
 gem 'fastlane', group: :fastlane_dependencies
 gem 'json'
+gem 'lefthook'
 gem 'rubocop', '1.38', group: :rubocop_dependencies
 gem 'sinatra', group: :sinatra_dependencies
 gem 'slather'

Gemfile.lock

@@ -273,6 +273,7 @@ GEM
       rexml (>= 3.3.9)
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
+    lefthook (1.11.16)
     logger (1.7.0)
     method_source (1.1.0)
     mini_magick (4.13.2)
@@ -427,6 +428,7 @@ DEPENDENCIES
   fastlane-plugin-stream_actions (= 0.3.84)
   fastlane-plugin-versioning
   json
+  lefthook
   plist
   puma
   rackup

Scripts/bootstrap.sh

@@ -20,15 +20,11 @@ trap "echo ; echo ❌ The Bootstrap script failed to finish without error. See t
 
 source ./Githubfile
 
-puts "Create git/hooks folder if needed"
-mkdir -p .git/hooks
-
-# Symlink hooks folder to .git/hooks folder
-puts "Create symlink for pre-commit hooks"
-# Symlink needs to be ../../hooks and not ./hooks because git evaluates them in .git/hooks
-ln -sf ../../hooks/pre-commit.sh .git/hooks/pre-commit
-chmod +x .git/hooks/pre-commit
-chmod +x ./hooks/git-format-staged
+if [ "${GITHUB_ACTIONS:-}" != "true" ]; then
+  puts "Set up git hooks"
+  bundle install
+  bundle exec lefthook install
+fi
 
 if [ "${SKIP_MINT_BOOTSTRAP:-}" != true ]; then
   puts "Bootstrap Mint dependencies"

fastlane/Fastfile

@@ -20,8 +20,6 @@ reversed_gci = gci.split('.').reverse.join('.')
 is_localhost = !is_ci
 @force_check = false
 swift_environment_path = File.absolute_path('../Sources/StreamVideo/Generated/SystemEnvironment+Version.swift')
-swiftformat_excluded_paths = ["**/Generated", "**/generated", "**/protobuf", "**/OpenApi"]
-swiftformat_source_paths = ["Sources", "DemoApp", "DemoAppUIKit", "StreamVideoTests", "StreamVideoSwiftUITests", "StreamVideoUIKitTests"]
 
 before_all do |lane|
   if is_ci
@@ -673,10 +671,13 @@ end
 desc 'Run source code formatting/linting'
 lane :run_swift_format do |options|
   Dir.chdir('..') do
-    action = options[:lint] ? "--lint" : ""
-    swiftformat_source_paths.each do |path|
-      sh("mint run swiftformat #{action} --config .swiftformat --exclude #{swiftformat_excluded_paths.join(',')} #{path}")
-      sh("mint run swiftlint lint --config .swiftlint.yml --progress --quiet --reporter json #{path}")
+    strict = options[:strict] ? '--lint' : nil
+    sources_matrix[:swiftformat_include].each do |path|
+      sh("mint run swiftformat #{strict} --config .swiftformat --exclude #{sources_matrix[:swiftformat_exclude].join(',')} #{path}")
+      next if path.include?('Tests')
+
+      sh("mint run swiftlint lint --config .swiftlint.yml --fix --progress --quiet --reporter json #{path}") unless strict
+      sh("mint run swiftlint lint --config .swiftlint.yml --strict --progress --quiet --reporter json #{path}")
     end
   end
 end
@@ -708,7 +709,9 @@ lane :sources_matrix do
     documentation_tests: ['Sources', 'DocumentationTests', xcode_project],
     size: ['Sources', xcode_project],
     public_interface: ['Sources'],
-    ruby: ['fastlane']
+    ruby: ['fastlane'],
+    swiftformat_include: ["Sources", "DemoApp", "DemoAppUIKit", "StreamVideoTests", "StreamVideoSwiftUITests", "StreamVideoUIKitTests"],
+    swiftformat_exclude: ["**/Generated", "**/generated", "**/protobuf", "**/OpenApi"]
   }
 end