[Fix]Respect dashboard callSettings for outgoing calls when no local settings provided (#841)

Author: ipavlidakis

CHANGELOG.md

@@ -4,7 +4,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 # Upcoming
 
-### 🔄 Changed
+### 🐞 Fixed
+- The CallViewModel will now respect the dashboard's `CallSettings` when starting a `Call` with `ring:true` and without provided `CallSettings`. [#841](https://github.com/GetStream/stream-video-swift/pull/841)
 
 # [1.24.0](https://github.com/GetStream/stream-video-swift/releases/tag/1.24.0)
 _June 02, 2025_

Sources/StreamVideoSwiftUI/CallViewModel.swift

@@ -363,6 +363,9 @@ open class CallViewModel: ObservableObject {
                 customData: customData
             )
         } else {
+            /// If no CallSettings have been provided, we skip passing the default ones, in order to
+            /// respect any dashboard changes.
+            let callSettings = localCallSettingsChange ? callSettings : nil
             let call = streamVideo.call(
                 callType: callType,
                 callId: callId,

StreamVideoSwiftUITests/CallViewModel_Tests.swift

@@ -36,6 +36,73 @@ final class CallViewModel_Tests: StreamVideoTestCase, @unchecked Sendable {
         super.tearDown()
     }
 
+    @MainActor
+    func test_startCall_withoutLocalCallSettingsAndRingTrue_respectsDashboardSettings() async throws {
+        // Given
+        let mockCall = MockCall(.dummy(callType: .default, callId: callId))
+        await streamVideo?.disconnect()
+        streamVideo = nil
+        let mockStreamVideo = MockStreamVideo()
+        mockStreamVideo.stub(for: .call, with: mockCall)
+        let callViewModel = CallViewModel()
+
+        // When
+        callViewModel.startCall(
+            callType: .default,
+            callId: callId,
+            members: participants,
+            ring: true
+        )
+
+        // Then
+        XCTAssertEqual(mockStreamVideo.timesCalled(.call), 1)
+        let (
+            recordedCallType,
+            recordedCallId,
+            recordedCallSettings
+        ) = try XCTUnwrap(
+            mockStreamVideo
+                .recordedInputPayload((String, String, CallSettings?).self, for: .call)?.first
+        )
+        XCTAssertEqual(recordedCallType, callType)
+        XCTAssertEqual(recordedCallId, callId)
+        XCTAssertNil(recordedCallSettings)
+    }
+
+    @MainActor
+    func test_startCall_withLocalCallSettingsAndRingTrue_respectsLocalSettings() async throws {
+        // Given
+        let mockCall = MockCall(.dummy(callType: .default, callId: callId))
+        await streamVideo?.disconnect()
+        streamVideo = nil
+        let mockStreamVideo = MockStreamVideo()
+        mockStreamVideo.stub(for: .call, with: mockCall)
+        let callViewModel = CallViewModel(callSettings: .init(audioOn: false, audioOutputOn: false))
+
+        // When
+        callViewModel.startCall(
+            callType: .default,
+            callId: callId,
+            members: participants,
+            ring: true
+        )
+
+        // Then
+        XCTAssertEqual(mockStreamVideo.timesCalled(.call), 1)
+        let (
+            recordedCallType,
+            recordedCallId,
+            recordedCallSettings
+        ) = try XCTUnwrap(
+            mockStreamVideo
+                .recordedInputPayload((String, String, CallSettings?).self, for: .call)?.first
+        )
+        XCTAssertEqual(recordedCallType, callType)
+        XCTAssertEqual(recordedCallId, callId)
+        XCTAssertFalse(recordedCallSettings?.audioOn ?? true)
+        XCTAssertFalse(recordedCallSettings?.audioOutputOn ?? true)
+    }
+
     @MainActor
     func test_startCall_joiningState() {
         // Given

StreamVideoTests/Mock/MockCall.swift

@@ -8,6 +8,7 @@ import Foundation
 final class MockCall: Call, Mockable, @unchecked Sendable {
 
     typealias FunctionKey = MockCallFunctionKey
+    typealias FunctionInputKey = MockCallFunctionInputKey
 
     enum MockCallFunctionKey: Hashable, CaseIterable {
         case get
@@ -52,9 +53,8 @@ final class MockCall: Call, Mockable, @unchecked Sendable {
 
     var stubbedProperty: [String: Any]
     var stubbedFunction: [FunctionKey: Any] = [:]
-    @Atomic var stubbedFunctionInput: [FunctionKey: [MockCallFunctionInputKey]] = MockCallFunctionKey
-        .allCases
-        .reduce(into: [FunctionKey: [MockCallFunctionInputKey]]()) { $0[$1] = [] }
+    @Atomic var stubbedFunctionInput: [FunctionKey: [FunctionInputKey]] = FunctionKey.allCases
+        .reduce(into: [FunctionKey: [FunctionInputKey]]()) { $0[$1] = [] }
 
     override var state: CallState {
         get { self[dynamicMember: \.state] }

StreamVideoTests/Mock/MockStreamVideo.swift

@@ -7,16 +7,32 @@ import Foundation
 
 final class MockStreamVideo: StreamVideo, Mockable, @unchecked Sendable {
     typealias FunctionKey = MockStreamVideoFunctionKey
-    typealias FunctionInputKey = EmptyPayloadable
+    typealias FunctionInputKey = MockFunctionInputKey
 
     enum MockStreamVideoFunctionKey: Hashable, CaseIterable {
         case call
         case connect
     }
 
+    enum MockFunctionInputKey: Payloadable {
+        case call(
+            callType: String,
+            callId: String,
+            callSettings: CallSettings?
+        )
+
+        var payload: Any {
+            switch self {
+            case let .call(callType, callId, callSettings):
+                return (callType, callId, callSettings)
+            }
+        }
+    }
+
     var stubbedProperty: [String: Any] = [:]
     var stubbedFunction: [FunctionKey: Any] = [:]
-    var stubbedFunctionInput: [FunctionKey: [FunctionInputKey]] = [:]
+    @Atomic var stubbedFunctionInput: [FunctionKey: [FunctionInputKey]] = FunctionKey.allCases
+        .reduce(into: [FunctionKey: [FunctionInputKey]]()) { $0[$1] = [] }
 
     override var state: StreamVideo.State {
         get { self[dynamicMember: \.state] }
@@ -67,7 +83,14 @@ final class MockStreamVideo: StreamVideo, Mockable, @unchecked Sendable {
         callId: String,
         callSettings: CallSettings? = nil
     ) -> Call {
-        stubbedFunction[.call] as! Call
+        stubbedFunctionInput[.call]?.append(
+            .call(
+                callType: callType,
+                callId: callId,
+                callSettings: callSettings
+            )
+        )
+        return stubbedFunction[.call] as! Call
     }
 
     override func connect() async throws {