fix(ui): fix message input command, attachment button incorrect assertion (#2145)

* fix(ui): fix message input command, attachment button incorrect assertion.

* chore: update CHANGELOG.md

* chore: fix changelog issue number

Author: xsahil03x

packages/stream_chat_flutter/CHANGELOG.md

@@ -1,6 +1,15 @@
+## Upcoming
+
+🐞 Fixed
+
+- [[#2118]](https://github.com/GetStream/stream-chat-flutter/issues/2118) Fixed invalid assertions
+  applied on message input command and attachment button.
+
 ## 9.6.0
 
-- [[#2118]](https://github.com/GetStream/stream-chat-flutter/issues/2118) Fixed message input
+🐞 Fixed
+
+- [[#2137]](https://github.com/GetStream/stream-chat-flutter/issues/2137) Fixed message input
   buttons not being able to customized.
 - [[#1775]](https://github.com/GetStream/stream-chat-flutter/issues/1775) Fix incorrect message order.
 

packages/stream_chat_flutter/lib/src/message_input/attachment_button.dart

@@ -13,11 +13,7 @@ class AttachmentButton extends StatelessWidget {
     this.color,
     this.icon,
     this.size = kDefaultMessageInputIconSize,
-  }) : assert(
-            (icon == null && color == null) ||
-                (icon != null && color == null) ||
-                (icon == null && color != null),
-            'Either icon or color should be provided');
+  });
 
   /// The color of the button.
   /// Should be set if no [icon] is provided.

packages/stream_chat_flutter/lib/src/message_input/command_button.dart

@@ -13,11 +13,7 @@ class CommandButton extends StatelessWidget {
     this.color,
     this.icon,
     this.size = kDefaultMessageInputIconSize,
-  }) : assert(
-            (icon == null && color == null) ||
-                (icon != null && color == null) ||
-                (icon == null && color != null),
-            'Either icon or color should be provided');
+  });
 
   /// The color of the button.
   /// Should be set if no [icon] is provided.

packages/stream_chat_flutter/test/src/message_input/attachment_button_test.dart

@@ -7,16 +7,14 @@ import 'package:stream_chat_flutter/stream_chat_flutter.dart';
 import '../material_app_wrapper.dart';
 
 void main() {
-  testWidgets('SendButton onPressed works', (tester) async {
+  testWidgets('AttachmentButton onPressed works', (tester) async {
     var count = 0;
     await tester.pumpWidget(
       MaterialApp(
         home: Scaffold(
           body: Center(
             child: AttachmentButton(
-              color: StreamChatThemeData.light()
-                  .messageInputTheme
-                  .actionButtonIdleColor,
+              color: Colors.red,
               onPressed: () {
                 count++;
               },
@@ -33,6 +31,45 @@ void main() {
     expect(count, 1);
   });
 
+  testWidgets('AttachmentButton should accept icon', (tester) async {
+    const icon = Icon(Icons.attachment);
+    await tester.pumpWidget(
+      MaterialApp(
+        home: Scaffold(
+          body: Center(
+            child: AttachmentButton(
+              icon: icon,
+              onPressed: () {},
+            ),
+          ),
+        ),
+      ),
+    );
+
+    expect(find.byIcon(Icons.attachment), findsOneWidget);
+  });
+
+  testWidgets('AttachmentButton should accept color', (tester) async {
+    await tester.pumpWidget(
+      MaterialApp(
+        home: Scaffold(
+          body: Center(
+            child: AttachmentButton(
+              color: Colors.red,
+              onPressed: () {},
+            ),
+          ),
+        ),
+      ),
+    );
+
+    final buttonFinder = find.byType(AttachmentButton);
+    expect(buttonFinder, findsOneWidget);
+
+    final button = tester.widget<AttachmentButton>(buttonFinder);
+    expect(button.color, Colors.red);
+  });
+
   goldenTest(
     'golden test for AttachmentButton',
     fileName: 'attachment_button_0',

packages/stream_chat_flutter/test/src/message_input/command_button_test.dart

@@ -44,32 +44,28 @@ void main() {
       ),
     );
 
-    final iconFound = find.byWidget(icon);
-    expect(iconFound, findsOneWidget);
+    expect(find.byIcon(Icons.add), findsOneWidget);
   });
 
-  testWidgets('CommandButton should not accept both color and icon',
-      (tester) async {
-    expect(
-      () => MaterialApp(
+  testWidgets('CommandButton should accept color', (tester) async {
+    await tester.pumpWidget(
+      MaterialApp(
         home: Scaffold(
           body: Center(
             child: CommandButton(
               color: Colors.red,
-              icon: const Icon(Icons.add),
               onPressed: () {},
             ),
           ),
         ),
       ),
-      throwsA(
-        isA<AssertionError>().having(
-          (e) => e.message,
-          'message',
-          'Either icon or color should be provided',
-        ),
-      ),
     );
+
+    final buttonFinder = find.byType(CommandButton);
+    expect(buttonFinder, findsOneWidget);
+
+    final button = tester.widget<CommandButton>(buttonFinder);
+    expect(button.color, Colors.red);
   });
 
   goldenTest(