Remove unnecessary Result<(), Alloc> from send_message

Author: KronicDeth

liblumen_alloc/src/erts/process.rs

@@ -336,11 +336,7 @@ impl ProcessControlBlock {
 
     // Send
 
-    pub fn send_heap_message(
-        &self,
-        heap_fragment: NonNull<HeapFragment>,
-        data: Term,
-    ) -> Result<(), Alloc> {
+    pub fn send_heap_message(&self, heap_fragment: NonNull<HeapFragment>, data: Term) {
         let heap_fragment_ptr = heap_fragment.as_ptr();
 
         let off_heap_unsafe_ref_heap_fragment = unsafe { UnsafeRef::from_raw(heap_fragment_ptr) };
@@ -353,11 +349,11 @@ impl ProcessControlBlock {
         self.send_message(Message::HeapFragment(message::HeapFragment {
             unsafe_ref_heap_fragment: message_unsafe_ref_heap_fragment,
             data,
-        }))
+        }));
     }
 
-    pub fn send_from_self(&self, data: Term) -> Result<(), Alloc> {
-        self.send_message(Message::Process(message::Process { data }))
+    pub fn send_from_self(&self, data: Term) {
+        self.send_message(Message::Process(message::Process { data }));
     }
 
     /// Returns `true` if the process should stop waiting and be rescheduled as runnable.
@@ -368,12 +364,12 @@ impl ProcessControlBlock {
 
                 self.send_message(Message::Process(message::Process {
                     data: destination_data,
-                }))?;
+                }));
             }
             None => {
                 let (heap_fragment_data, heap_fragment) = data.clone_to_fragment()?;
 
-                self.send_heap_message(heap_fragment, heap_fragment_data)?;
+                self.send_heap_message(heap_fragment, heap_fragment_data);
             }
         }
 
@@ -391,10 +387,8 @@ impl ProcessControlBlock {
         }
     }
 
-    fn send_message(&self, message: Message) -> Result<(), Alloc> {
-        self.mailbox.lock().borrow_mut().push(message);
-
-        Ok(())
+    fn send_message(&self, message: Message) {
+        self.mailbox.lock().borrow_mut().push(message)
     }
 
     // Terms

lumen_runtime/src/otp/erlang.rs

@@ -1800,7 +1800,7 @@ fn cancel_timer(
                                 timer_reference,
                                 canceled_term,
                             ])?;
-                            process_control_block.send_from_self(cancel_timer_message)?;
+                            process_control_block.send_from_self(cancel_timer_message);
 
                             atom_unchecked("ok")
                         } else {
@@ -1914,7 +1914,7 @@ fn read_timer(
                             timer_reference,
                             read_term,
                         ])?;
-                        process_control_block.send_from_self(read_timer_message)?;
+                        process_control_block.send_from_self(read_timer_message);
 
                         atom_unchecked("ok")
                     } else {

lumen_runtime/src/otp/erlang/tests/cancel_timer_1/with_local_reference/with_timer/in_different_thread.rs

@@ -140,7 +140,7 @@ where
 
 fn timeout_after_half(milliseconds: Milliseconds, barrier: &Barrier) {
     thread::sleep(Duration::from_millis(milliseconds / 2 + 1));
-    timer::timeout().unwrap();
+    timer::timeout();
     barrier.wait();
 }
 

lumen_runtime/src/otp/erlang/tests/cancel_timer_1/with_local_reference/with_timer/in_same_thread.rs

@@ -10,7 +10,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
         let half_milliseconds = milliseconds / 2;
 
         thread::sleep(Duration::from_millis(half_milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         let timeout_message = timeout_message(timer_reference, message, process);
 
@@ -34,7 +34,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
         );
 
         thread::sleep(Duration::from_millis(half_milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         assert!(!has_message(process, timeout_message));
 
@@ -50,7 +50,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
 fn with_timeout_returns_false_after_timeout_message_was_sent() {
     with_timer(|milliseconds, message, timer_reference, process| {
         thread::sleep(Duration::from_millis(milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         let timeout_message = timeout_message(timer_reference, message, process);
 

lumen_runtime/src/otp/erlang/tests/cancel_timer_2/with_reference_timer_reference/with_empty_list_options/with_local_reference/with_timer/in_different_thread.rs

@@ -138,7 +138,7 @@ where
 
 fn timeout_after_half(milliseconds: Milliseconds, barrier: &Barrier) {
     thread::sleep(Duration::from_millis(milliseconds / 2 + 1));
-    timer::timeout().unwrap();
+    timer::timeout();
     barrier.wait();
 }
 

lumen_runtime/src/otp/erlang/tests/cancel_timer_2/with_reference_timer_reference/with_empty_list_options/with_local_reference/with_timer/in_same_thread.rs

@@ -9,7 +9,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
         let half_milliseconds = milliseconds / 2;
 
         thread::sleep(Duration::from_millis(half_milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         let timeout_message = timeout_message(timer_reference, message, process);
 
@@ -32,7 +32,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
         );
 
         thread::sleep(Duration::from_millis(half_milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         assert!(!has_message(process, timeout_message));
 
@@ -48,7 +48,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
 fn with_timeout_returns_false_after_timeout_message_was_sent() {
     with_timer(|milliseconds, message, timer_reference, process| {
         thread::sleep(Duration::from_millis(milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         let timeout_message = timeout_message(timer_reference, message, process);
 

lumen_runtime/src/otp/erlang/tests/cancel_timer_2/with_reference_timer_reference/with_list_options/with_async_false/with_info_false/with_local_reference/with_timer/in_different_thread.rs

@@ -137,7 +137,7 @@ where
 
 fn timeout_after_half(milliseconds: Milliseconds, barrier: &Barrier) {
     thread::sleep(Duration::from_millis(milliseconds / 2 + 1));
-    timer::timeout().unwrap();
+    timer::timeout();
     barrier.wait();
 }
 

lumen_runtime/src/otp/erlang/tests/cancel_timer_2/with_reference_timer_reference/with_list_options/with_async_false/with_info_false/with_local_reference/with_timer/in_same_thread.rs

@@ -9,7 +9,7 @@ fn without_timeout_returns_ok_and_does_not_send_timeout_message() {
         let half_milliseconds = milliseconds / 2;
 
         thread::sleep(Duration::from_millis(half_milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         let timeout_message = timeout_message(timer_reference, message, process);
 
@@ -27,7 +27,7 @@ fn without_timeout_returns_ok_and_does_not_send_timeout_message() {
         );
 
         thread::sleep(Duration::from_millis(half_milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         assert!(!has_message(process, timeout_message));
 
@@ -43,7 +43,7 @@ fn without_timeout_returns_ok_and_does_not_send_timeout_message() {
 fn with_timeout_returns_ok_after_timeout_message_was_sent() {
     with_timer(|milliseconds, message, timer_reference, process| {
         thread::sleep(Duration::from_millis(milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         let timeout_message = timeout_message(timer_reference, message, process);
 

lumen_runtime/src/otp/erlang/tests/cancel_timer_2/with_reference_timer_reference/with_list_options/with_async_false/with_info_true/with_local_reference/with_timer/in_different_thread.rs

@@ -140,7 +140,7 @@ where
 
 fn timeout_after_half(milliseconds: Milliseconds, barrier: &Barrier) {
     thread::sleep(Duration::from_millis(milliseconds / 2 + 1));
-    timer::timeout().unwrap();
+    timer::timeout();
     barrier.wait();
 }
 

lumen_runtime/src/otp/erlang/tests/cancel_timer_2/with_reference_timer_reference/with_list_options/with_async_false/with_info_true/with_local_reference/with_timer/in_same_thread.rs

@@ -10,7 +10,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
         let half_milliseconds = milliseconds / 2;
 
         thread::sleep(Duration::from_millis(half_milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         let timeout_message = timeout_message(timer_reference, message, process);
 
@@ -34,7 +34,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
         );
 
         thread::sleep(Duration::from_millis(half_milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         assert!(!has_message(process, timeout_message));
 
@@ -50,7 +50,7 @@ fn without_timeout_returns_milliseconds_remaining_and_does_not_send_timeout_mess
 fn with_timeout_returns_false_after_timeout_message_was_sent() {
     with_timer(|milliseconds, message, timer_reference, process| {
         thread::sleep(Duration::from_millis(milliseconds + 1));
-        timer::timeout().unwrap();
+        timer::timeout();
 
         let timeout_message = timeout_message(timer_reference, message, process);