Skip to content

Commit 8172102

Browse files
weiji14seisman
andcommitted
Simplify to remove getattr(pa, "array", None) call
Co-Authored-By: Dongdong Tian <seisman.info@gmail.com>
1 parent edb3438 commit 8172102

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

pygmt/tests/test_clib_virtualfile_from_vectors.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@
1515

1616
try:
1717
import pyarrow as pa
18+
19+
pa_array = pa.array
1820
except ImportError:
19-
pa = None
21+
pa_array = None
2022

2123

2224
@pytest.fixture(scope="module", name="dtypes")
@@ -65,8 +67,8 @@ def test_virtualfile_from_vectors(dtypes):
6567
pytest.param(np.array, {"dtype": np.str_}, id="str"),
6668
pytest.param(np.array, {"dtype": np.object_}, id="object"),
6769
pytest.param(
68-
getattr(pa, "array", None),
69-
{}, # pa.string()
70+
pa_array,
71+
{}, # {"type": pa.string()}
7072
marks=skip_if_no(package="pyarrow"),
7173
id="pyarrow",
7274
),

pygmt/tests/test_text.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@
1313

1414
try:
1515
import pyarrow as pa
16+
17+
pa_array = pa.array
1618
except ImportError:
17-
pa = None
19+
pa_array = None
1820

1921
TEST_DATA_DIR = Path(__file__).parent / "data"
2022
POINTS_DATA = TEST_DATA_DIR / "points.txt"
@@ -60,11 +62,7 @@ def test_text_single_line_of_text(region, projection):
6062
[
6163
list,
6264
pytest.param(np.array, id="numpy"),
63-
pytest.param(
64-
getattr(pa, "array", None),
65-
marks=skip_if_no(package="pyarrow"),
66-
id="pyarrow",
67-
),
65+
pytest.param(pa_array, marks=skip_if_no(package="pyarrow"), id="pyarrow"),
6866
],
6967
)
7068
def test_text_multiple_lines_of_text(region, projection, array_func):

0 commit comments

Comments
 (0)