Skip to content

Commit 68c3b97

Browse files
authored
Do NOT fail CI if codecov runs into errors during upload (#1032)
The codecov github action is very unstable recently, and make most of our CI jobs fail. This PR sets `fail_ci_if_error` to `false` (the default behavior of codecov), so that even if codecov fails in uploading the coverage reports, the CI job still pass. Actually, if the codecov upload fails, we will see the failing codecov checks, but at least we know that all tests pass. [skip ci]
1 parent 2a70379 commit 68c3b97

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci_tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jobs:
134134
with:
135135
file: ./coverage.xml # optional
136136
env_vars: OS,PYTHON
137-
fail_ci_if_error: true
137+
fail_ci_if_error: false
138138

139139
- name: Checkout the gh-pages branch
140140
uses: actions/checkout@28c7f3d2b5162b5ddd3dfd9a45aa55eaf396478b

0 commit comments

Comments
 (0)