Skip to content

102 plot decision #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

102 plot decision #136

wants to merge 66 commits into from

Conversation

audreyyeoCH
Copy link
Collaborator

close #102

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              81       3  96.30%   32, 62, 136
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      166       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                63       5  92.06%   106-110
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            51       0  100.00%
R/plotOc.R                  50       2  96.00%   94-95
R/postprob.R                34       1  97.06%   106
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumBetaDiff.R             80      15  81.25%   102-120
R/sumTable.R                36       0  100.00%
TOTAL                     2328     398  82.90%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/plotDecision.R      -28     -79  +100.00%
R/sumBetaDiff.R       +80     +15  +81.25%
TOTAL                 +52     -64  +3.25%

Results for commit: 2d98b58

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ocPredprobDist 💔 $89.72$ $+5.73$ $0$ $0$ $0$ $0$
plotDecision 👶 $+1.75$ $+9$ $+1$ $0$ $0$
plotOc 💔 $201.47$ $+4.00$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ocPredprobDist 💔 $23.12$ $+1.51$ ocPredprobDist_gives_higher_PrEfficacy_with_more_efficacy_looks
ocPredprobDist 💔 $57.77$ $+3.71$ ocPredprobDist_gives_higher_PrFutility_with_more_futility_looks
plotDecision 👶 $+1.75$ plotDecision_gives_a_correct_result
plotOc 💔 $53.51$ $+1.63$ h_get_dataframe_oc_gives_correct_results_for_ocPredprobDist_when_relativeDelta_FALSE
plotOc 💔 $99.03$ $+1.90$ plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status
sumbetadiff 👶 $+0.01$ sumBetaDiff_gives_a_error_when_at_least_one_alpha_0
sumbetadiff 👶 $+0.10$ sumBetaDiff_works_as_expected
sumbetadiff 💀 $0.01$ $-0.01$ sumbetadiff_gives_a_error_when_at_least_one_alpha_0
sumbetadiff 💀 $0.10$ $-0.10$ sumbetadiff_works_as_expected

Results for commit 07e7a66

♻️ This comment has been updated with latest results.

audreyyeoCH and others added 2 commits May 12, 2025 20:18
@audreyyeoCH @github-actions
@danielinteractive @dependabot-preview
101 sum table (#133)
c743510 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
622b583
@audreyyeoCH audreyyeoCH marked this pull request as draft May 12, 2025 22:19
audreyyeoCH and others added 4 commits May 13, 2025 10:45
@audreyyeoCH
clean
3e4f0a9
@audreyyeoCH @github-actions
@danielinteractive @dependabot-preview
101 sum table (#133)
74619fc 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
@audreyyeoCH
clean
7d6592f
@audreyyeoCH
annotation done
74b3682
@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented May 13, 2025 •
edited
Loading

Hi @danielinteractive before I do snaps, could you kindly review this plot from the example file please ? I used the same colours as plotBetaDiff :
image

Edit, the last previous version here
image

Edit, will add "%"

@audreyyeoCH audreyyeoCH marked this pull request as ready for review May 13, 2025 10:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2025 •
edited
Loading

Unit Tests Summary

    1 files     20 suites   6m 3s ⏱️
  136 tests   135 ✅ 1 💤 0 ❌
1 307 runs  1 303 ✅ 4 💤 0 ❌

Results for commit 3cc7c8f.

♻️ This comment has been updated with latest results.

@danielinteractive
Copy link
Collaborator

Looks good @audreyyeoCH !

@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented May 13, 2025 •
edited
Loading

thanks @danielinteractive, it's ready for another review
copying updated plot :
image

danielinteractive
danielinteractive approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor doc comment , afterwards ok to merge

@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented May 19, 2025 •
edited
Loading

3fc44c7

thanks, one more question though, see above

audreyyeoCH
audreyyeoCH commented May 20, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

102_plotDecision
2 participants
@audreyyeoCH @danielinteractive