PHPCBF Functionality

[rtvenge]

Thank you so much for making this extension! It is terrific!

One question I had was regarding phpcbf. It seems that your extension supports it (I saw you can set the path for it in settings) but I can't find how to use it. My assumption was that format_on_save would trigger it, but I could be wrong. 😄

[mikebronner]

@rtvenge thank you for reaching out. The code actions feature using PHPCBF is not actually implemented yet, it's on my list for things to add. I wanted to nail down the linting aspect first, and make sure that was all working as intended. I haven't seen any issues in quite a while now, so probably will start working on the code actions feature next month.

I'll be honest, I have developed a coding style for myself where I shun all automatic corrections in favor of the linters forcing me to correct it manually. Over time this has trained me to adhere to code style automatically, so that I rarely have linter warnings when I code. But I do see the benefit in it for PR automation, etc.

[rtvenge]

@mikebronner Thanks for the response!

Totally get that. I just wanted to make sure I wasn't missing anything. 😄

I can see that and appreciate it. For me as a WordPress developer, there are some mundane things that I prefer to automatically get fixed. Mostly whitespace stuff like arrows aligning in arrays, spaces around before and after arguments, etc.

Let me know if I can help in any way.

Thanks again for the extension!

[rtvenge]

I also found a pretty good workaround for now which is Zed Tasks:

My ~/.config/zed.tasks.json file

[
  {
    "label": "PHPCBF: Fix current file",
    "command": "/Users/ryantvenge/.composer/vendor/bin/phpcbf",
    "args": [
      "--standard=phpcs.xml",
      "$ZED_FILE"
    ],
    "reveal": "no_focus",
    "hide": "always",
    "shell": "system",
    "show_command": false
  }
]

That works well enough for me. 😄

[bmsimo]

I also found a pretty good workaround for now which is Zed Tasks:

My ~/.config/zed.tasks.json file

[
  {
    "label": "PHPCBF: Fix current file",
    "command": "/Users/ryantvenge/.composer/vendor/bin/phpcbf",
    "args": [
      "--standard=phpcs.xml",
      "$ZED_FILE"
    ],
    "reveal": "no_focus",
    "hide": "always",
    "shell": "system",
    "show_command": false
  }
]

That works well enough for me. 😄

This worked for me too, although , since i'm using DDEV inside WSL2, this was my config:

  {
        "label": "PHPCBF: Fix current file",
        "command": "$ABSOLUTE_PATH_TO_PROJECT/.ddev/commands/host/phpcbf-ddev",
        "args": ["--standard=Drupal", "$ZED_RELATIVE_FILE"],
        "reveal": "no_focus",
        "hide": "always",
        "shell": "system",
        "show_command": false
    }

phpcbf-ddev is just a wrapper:

#!/bin/zsh
ddev exec phpcbf "$@"