Skip to content

Commit a0cf397

Browse files
hatooGae24
authored andcommitted
Fix visual_studio.py to call vswhere with -utf8 (servo#32949)
In Japanese Windows, `vswhere` puts cp932 string in default and fails to load json in Pyhton. This fixes it by adding `-utf8` option Signed-off-by: hatoo <hato2000@gmail.com>
1 parent 6eadb86 commit a0cf397

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

python/servo/visual_studio.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ def find_compatible_msvc_with_vswhere() -> Generator[VisualStudioInstallation, N
5757
'-format', 'json',
5858
'-products', '*',
5959
'-requires', 'Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
60-
'-requires', 'Microsoft.VisualStudio.Component.Windows10SDK'
60+
'-requires', 'Microsoft.VisualStudio.Component.Windows10SDK',
61+
'-utf8'
6162
]).decode(errors='ignore')
6263

6364
for install in json.loads(output):

0 commit comments

Comments
 (0)