Skip to content

Commit f0017d9

Browse files
committed
Rename android args to have underscore
Also added file I missed in the last commit.
1 parent 7d7f4ee commit f0017d9

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

build/pre_build.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ def pre_build(build_args):
3333

3434
build_dir_name = "cmake_bld"
3535

36-
if build_args.androidx64 == True:
36+
if build_args.android_x64 == True:
3737
build_dir_name = "cmake_bld_android_x64"
38-
elif build_args.androidarm64 == True:
38+
elif build_args.android_arm64 == True:
3939
build_dir_name = "cmake_bld_android_arm64"
4040

4141
cmake_additional_args = PreBuildCMakeCommon.parse_cmake_arguments(build_args)
@@ -45,7 +45,7 @@ def pre_build(build_args):
4545
else:
4646
cmake_additional_args.append("-Dbuild=0")
4747

48-
if build_args.androidx64 == True or build_args.androidarm64 == True:
48+
if build_args.android_x64 == True or build_args.android_arm64 == True:
4949
PreBuildCMakeCommon.cmake_generator_platforms.remove('x86')
5050
android_ndk=os.environ["ANDROID_NDK"]
5151
if android_ndk == "":
@@ -60,9 +60,9 @@ def pre_build(build_args):
6060
cmake_additional_args.append("-Dskiptests=ON")
6161
cmake_additional_args.append("-Dbuild-32bit=OFF")
6262

63-
if build_args.androidx64 == True:
63+
if build_args.android_x64 == True:
6464
cmake_additional_args.append("-DANDROID_ABI=x86_64")
65-
elif build_args.androidarm64 == True:
65+
elif build_args.android_arm64 == True:
6666
cmake_additional_args.append("-DANDROID_ABI=arm64-v8a")
6767

6868
print(PreBuildCMakeCommon.cmake_generator)

scripts/pre_build_common.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,9 @@ def define_cmake_arguments():
127127
script_parser.add_argument("--nofetch", action="store_true", help="skip fetching repo dependencies")
128128
script_parser.add_argument("--cmakecmd", type=str, default="cmake", help="command to use in place of 'cmake'")
129129
script_parser.add_argument("--verbose", action="store_true", help="Turns on the verbosity of the script'")
130-
script_parser.add_argument("--android", action="store_true", help="CMake will generate project files for android")
130+
script_parser.add_argument("--android_x64", action="store_true", help="CMake will generate project files for Android x64")
131+
script_parser.add_argument("--android_arm64", action="store_true", help="CMake will generate project files for Android Arm-64")
132+
script_parser.add_argument("--android", dest="android_x64", action="store_true", help="Same as --android_x64 (for backwards compatibility)")
131133

132134
script_parser.add_argument("--clang_format", action="store_true", help="run clang-format on source files prior to performing a build")
133135
script_parser.add_argument("--clang_tidy", action="store_true", help="run clang-tidy on source files after a build completes")

0 commit comments

Comments
 (0)