Demo - clarify usage of last argument of rprContextResolveFrameBuffer.

Author: RichardGe

tutorials/05_basic_scene/main.cpp

@@ -134,8 +134,8 @@ int main()
 
 	// 'frame_buffer' is not supposed to be used for rendering, we need to process it with rprContextResolveFrameBuffer.
 	// This function transforms the raw 'frame_buffer' into a new 'frame_buffer_resolved' that can be displayed on screen as final rendering.
-	// The 'normalizeOnly' argument means we only want to do a normalization of 'frame_buffer'.
-	// In most of cases, this argument can be left to FALSE: this lets the Renderer choose the correct operation(s) to process.
+	// The 'noDisplayGamma'=false argument means we want to use display gamma (defined by RPR_CONTEXT_DISPLAY_GAMMA) which makes sense in this case as 'frame_buffer' represents COLOR.
+	// If the framebuffer doesn't represent Color ( for example: Normals, Depth, UVs ... ) then 'noDisplayGamma' should be set to true. 
 	CHECK(rprContextResolveFrameBuffer(context,frame_buffer,frame_buffer_resolved,false));
 
 	// save the rendering to an image file.

tutorials/12_transform_motion_blur/main.cpp

@@ -140,7 +140,7 @@ int main()
 	CHECK( rprContextSetParameterByKey1u(context,RPR_CONTEXT_ITERATIONS,200));
 	CHECK( rprContextRender(context) );
 	CHECK( rprContextResolveFrameBuffer(context,fb_color,fb_color_resolved,false));
-	CHECK( rprContextResolveFrameBuffer(context,fb_velocity,fb_velocity_resolved,false));
+	CHECK( rprContextResolveFrameBuffer(context,fb_velocity,fb_velocity_resolved,true));
 	CHECK( rprFrameBufferSaveToFile(fb_color_resolved, "12_0.png") );
 	std::cout << "Rendering 12_0 finished." << std::endl;
 
@@ -162,7 +162,7 @@ int main()
 	CHECK( rprFrameBufferClear(fb_velocity) );
 	CHECK( rprContextRender(context) );
 	CHECK( rprContextResolveFrameBuffer(context,fb_color,fb_color_resolved,false));
-	CHECK( rprContextResolveFrameBuffer(context,fb_velocity,fb_velocity_resolved,false));
+	CHECK( rprContextResolveFrameBuffer(context,fb_velocity,fb_velocity_resolved,true));
 	CHECK( rprFrameBufferSaveToFile(fb_color_resolved, "12_1.png") );
 	CHECK( rprFrameBufferSaveToFile(fb_velocity_resolved, "12_1v.png") );
 	std::cout << "Rendering 12_1 finished." << std::endl;
@@ -176,7 +176,7 @@ int main()
 	CHECK( rprFrameBufferClear(fb_velocity) );
 	CHECK( rprContextRender(context) );
 	CHECK( rprContextResolveFrameBuffer(context,fb_color,fb_color_resolved,false));
-	CHECK( rprContextResolveFrameBuffer(context,fb_velocity,fb_velocity_resolved,false));
+	CHECK( rprContextResolveFrameBuffer(context,fb_velocity,fb_velocity_resolved,true));
 	CHECK( rprFrameBufferSaveToFile(fb_color_resolved, "12_2.png") );
 	CHECK( rprFrameBufferSaveToFile(fb_velocity_resolved, "12_2v.png") );
 	std::cout << "Rendering 12_2 finished." << std::endl;
@@ -190,7 +190,7 @@ int main()
 	CHECK( rprFrameBufferClear(fb_velocity) );
 	CHECK( rprContextRender(context) );
 	CHECK( rprContextResolveFrameBuffer(context,fb_color,fb_color_resolved,false));
-	CHECK( rprContextResolveFrameBuffer(context,fb_velocity,fb_velocity_resolved,false));
+	CHECK( rprContextResolveFrameBuffer(context,fb_velocity,fb_velocity_resolved,true));
 	CHECK( rprFrameBufferSaveToFile(fb_color_resolved, "12_3.png") );
 	CHECK( rprFrameBufferSaveToFile(fb_velocity_resolved, "12_3v.png") );
 	std::cout << "Rendering 12_3 finished." << std::endl;

tutorials/33_aov/main.cpp

@@ -63,23 +63,25 @@ int main()
 	//
 	struct AOV_FB
 	{
-		AOV_FB(const std::string& name_, rpr_aov aov_)
+		AOV_FB(const std::string& name_, rpr_aov aov_, bool useDisplayGamma_)
 		{
 			framebuffer = nullptr;
 			framebuffer_res = nullptr;
 			name = name_;
 			aov = aov_;
+			useDisplayGamma = useDisplayGamma_; 
 		}
 		rpr_framebuffer framebuffer;
 		rpr_framebuffer framebuffer_res;
 		std::string name;
 		rpr_aov aov;
+		bool useDisplayGamma; // Set this parameter to TRUE for AOV representing Colors. For other AOVs storing data ( Normals, Depth ... ) make sure to set it to FALSE.
 	};
 	std::vector<AOV_FB> AOVlist;
-	AOVlist.push_back(AOV_FB("geom_normal" ,RPR_AOV_GEOMETRIC_NORMAL));
-	AOVlist.push_back(AOV_FB("shad_normal" ,RPR_AOV_SHADING_NORMAL));
-	AOVlist.push_back(AOV_FB("obj_id"      ,RPR_AOV_OBJECT_ID));
-	AOVlist.push_back(AOV_FB("uv"          ,RPR_AOV_UV));
+	AOVlist.push_back(AOV_FB("geom_normal" ,RPR_AOV_GEOMETRIC_NORMAL, false));
+	AOVlist.push_back(AOV_FB("shad_normal" ,RPR_AOV_SHADING_NORMAL, false));
+	AOVlist.push_back(AOV_FB("obj_id"      ,RPR_AOV_OBJECT_ID, false));
+	AOVlist.push_back(AOV_FB("uv"          ,RPR_AOV_UV, false));
 
 	// Create the list of AOVs
 	//
@@ -96,7 +98,7 @@ int main()
 	//
 	for(auto& i : AOVlist)
 	{
-		CHECK( rprContextResolveFrameBuffer(context, i.framebuffer, i.framebuffer_res, false) );
+		CHECK( rprContextResolveFrameBuffer(context, i.framebuffer, i.framebuffer_res, !i.useDisplayGamma) );
 		CHECK( rprFrameBufferSaveToFile(i.framebuffer_res,  std::string("33_"+i.name+".png").c_str() ) );
 		CHECK( rprObjectDelete(i.framebuffer) );
 		CHECK( rprObjectDelete(i.framebuffer_res) );

tutorials/common/common.cpp

@@ -299,7 +299,7 @@ void MatballScene::Render(const std::string& outImgFileName, int iterationCount)
 
 	if ( !m_usingHybridContext ) // There is no framebuffer resolve for Hyrbid
 	{
-		// last argument is FALSE because we don't want a simple normalization: we also want to apply the display gamma (changed with RPR_CONTEXT_DISPLAY_GAMMA)
+		// last argument is FALSE because we want to apply the display gamma (changed with RPR_CONTEXT_DISPLAY_GAMMA) to this COLOR AOV.
 		CHECK( rprContextResolveFrameBuffer(m_context, m_frame_buffer, m_frame_buffer_res, false) );
 
 		CHECK( rprFrameBufferSaveToFile(m_frame_buffer_res, outImgFileName.c_str() ) );