Beta 0.7

[not-nef]

New Features:

• The scrollbar and the footer are back
• The window can be resized now
• Markdown preview is fixed
• New Start page

---

This discussion was created from the release Beta 0.7.

[not-nef]

@rdbende can you give me a professional opinion on how readable my code is?

[rdbende]

Professional :) I like it.
And, yeah can give some opinion, though I wouldn't call myself professional.

Overall I think the code is readable, the only thing that makes it hard to read are the statements squeezed into one line

https://github.com/not-nef/onyx/blob/1f4665d320efc3632431d4d8fa9a87f126350626/src/main.py#L22-L23

https://github.com/not-nef/onyx/blob/1f4665d320efc3632431d4d8fa9a87f126350626/src/tabmanager.py#L96-L97

I used to write them like that too, but I realized that actually I don't save that many lines, however, when I read it later, it's much harder to just look at it and understand immediately what that part does.
There's an amazing tool called black, that detects things like this and automatically formats your code, and formats it in a way that really makes it easier to understand at a glance what the code is doing.

Otherwise what I found a bit smelly is the use of global variables, and the vars module.
I don't want to explain here why global variables are considered evil (in any programming language, actually), but in Onyx the global variables and the vars module could be replaced by object oriented programming in all places. Besides, OOP is much more logical and intuitive and thus makes it much easier for humans to understand the code.

[shameless plug]
I wrote a tool, that helps you detect problems and potential errors in your Tkinter program, and it also recommends good coding styles with Tkinter. You might find it useful for Onyx. flake8-tkinter ->

[not-nef]

Thanks a lot! will try out black right now. im a little bit scared of oop since i dont fully understand it so im gonna stick to global variables for a bit longer.

[arieltordiglione]

[rdbende]

It was not him. It was a spambot.

[arieltordiglione]

"I am punishing you by ignoring you, ghost. I hope you can feel the pain."
its a strange phrase hahaha

[im-coder-lg]

Yeah. I don't know how this BS even works here.

[tushantydv17]

what the fcuk is this, nd why I'm in the CC.

…

________________________________ From: SharonMiller2004 ***@***.***> Sent: 29 December 2022 04:51 To: Futura-Py/notes ***@***.***> Cc: Tushant yadav ***@***.***>; Mention ***@***.***> Subject: Re: [Futura-Py/notes] Beta 0.7 (Discussion #63) I was a really bad girl Punish me https://link.sv/sYkVs0 @davidvossel<https://github.com/davidvossel> @jogo<https://github.com/jogo> @rosstaylor<https://github.com/rosstaylor> @goddva<https://github.com/goddva> @mrunge<https://github.com/mrunge> @thehar<https://github.com/thehar> @roderickm<https://github.com/roderickm> @simonmoxon<https://github.com/simonmoxon> @atis<https://github.com/atis> @aaronorosen<https://github.com/aaronorosen> @jjzhang<https://github.com/jjzhang> @toastertaster<https://github.com/toastertaster> @brettbryant<https://github.com/brettbryant> @leifmadsen<https://github.com/leifmadsen> @pabelanger<https://github.com/pabelanger> @ted-ross<https://github.com/ted-ross> @kpfleming<https://github.com/kpfleming> @otherwiseguy<https://github.com/otherwiseguy> @datachomper<https://github.com/datachomper> @sruffell<https://github.com/sruffell> @unicell<https://github.com/unicell> @rhythm-28<https://github.com/rhythm-28> @utsavsai100<https://github.com/utsavsai100> @Akanksha-Sen<https://github.com/Akanksha-Sen> @amitavhad09<https://github.com/amitavhad09> @sajjad-yousuf-96<https://github.com/sajjad-yousuf-96> @SyedIzzatUllah<https://github.com/SyedIzzatUllah> @tushantydv17<https://github.com/tushantydv17> @tushar2k19<https://github.com/tushar2k19> @Niranjan15052001<https://github.com/Niranjan15052001> @sharuk2k3<https://github.com/sharuk2k3> @vollemmanoj<https://github.com/vollemmanoj> @AbhinavJuyal<https://github.com/AbhinavJuyal> @eyasir2047<https://github.com/eyasir2047> @yashshahk9<https://github.com/yashshahk9> @monikaits44<https://github.com/monikaits44> @Shelke12<https://github.com/Shelke12> @monalsingh10<https://github.com/monalsingh10> @typewriter221<https://github.com/typewriter221> @aditi1128<https://github.com/aditi1128> @Rahul5430<https://github.com/Rahul5430> @ranjananshu<https://github.com/ranjananshu> @niket3342<https://github.com/niket3342> @yogeshsingh010<https://github.com/yogeshsingh010> @Yogesh0803<https://github.com/Yogesh0803> @hitesh1199<https://github.com/hitesh1199> @ratneshjoshi2409<https://github.com/ratneshjoshi2409> @rohit-rout<https://github.com/rohit-rout> @anushapahariya<https://github.com/anushapahariya> @dharmeshtops<https://github.com/dharmeshtops> Come and lets have fun https://go.sv/ntAaaa — Reply to this email directly, view it on GitHub<#63 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZFFYDMUJJ3P6VFWDVUFUHTWPTDQNANCNFSM6AAAAAARXHNYJU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[im-coder-lg]

Well, that was the result of a large-scale attack. It has happened everywhere, so it is common rn.

[not-nef]

TO EVERYONE THAT WANTS TO KNOW WHY THEY GOT MENTIONED

This Discussion fell victim to a spambot who mentioned a few dozens of people. I am terribly sorry for the inconvenience. Have a nice day!

[im-coder-lg]

It was the result of a large-scale attack. We aren't alone w. r. t. the comments.