Skip to content

Commit 90926a9

Browse files
committed
fix: breaking changes in unit tests
1 parent fac6313 commit 90926a9

File tree

3 files changed

+23
-13
lines changed

3 files changed

+23
-13
lines changed

models/pinecone.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def openai_embeddings(self) -> OpenAIEmbeddings:
101101
return self._openai_embeddings
102102

103103
@property
104-
def pinecone(self):
104+
def pinecone(self) -> Pinecone:
105105
"""Pinecone lazy read-only property."""
106106
if self._pinecone is None:
107107
print("Initializing Pinecone...")

models/tests/test_configuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def test_env_overrides(self):
9898
assert mock_settings.openai_endpoint_image_size == "TEST_1024x768"
9999
assert mock_settings.openai_chat_cache is False
100100
assert mock_settings.openai_chat_model_name == "TEST_gpt-4"
101-
assert mock_settings.openai_prompt_model_name == "TEST_text-davinci-003"
101+
assert mock_settings.openai_prompt_model_name == "TEST_gpt-4"
102102
assert mock_settings.openai_chat_temperature == 1.0
103103
assert mock_settings.openai_chat_max_retries == 5
104104

models/tests/test_pinecone.py

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
import pinecone as oem_pinecone
1010
import pytest # pylint: disable=unused-import
11+
from pinecone import Pinecone
1112

1213
from models.conf import settings
1314
from models.pinecone import PineconeIndex
@@ -50,29 +51,38 @@ def test_04_initialize(self):
5051

5152
def test_05_delete(self):
5253
"""Test that the index can be deleted."""
53-
pinecone = PineconeIndex()
54-
indexes = oem_pinecone.manage.list_indexes()
55-
assert pinecone.index_name in indexes
54+
pinecone_index = PineconeIndex()
55+
56+
# pylint: disable=E1101
57+
api_key = settings.pinecone_api_key.get_secret_value()
58+
pinecone = Pinecone(api_key=api_key)
59+
indexes = pinecone.list_indexes().names()
60+
assert pinecone_index.index_name in indexes
5661
# pylint: disable=broad-except
5762
try:
58-
pinecone.delete()
63+
pinecone_index.delete()
5964
except Exception as e:
6065
assert False, f"Pinecone.delete() failed with exception: {e}"
6166

6267
def test_06_create(self):
6368
"""Test that the index can be created."""
64-
pinecone = PineconeIndex()
65-
indexes = oem_pinecone.manage.list_indexes()
66-
if pinecone.index_name in indexes:
67-
pinecone.delete()
69+
pinecone_index = PineconeIndex()
70+
71+
# pylint: disable=E1101
72+
api_key = settings.pinecone_api_key.get_secret_value()
73+
pinecone = Pinecone(api_key=api_key)
74+
75+
indexes = pinecone.list_indexes().names()
76+
if pinecone_index.index_name in indexes:
77+
pinecone_index.delete()
6878

6979
# pylint: disable=broad-except
7080
try:
71-
pinecone.create()
81+
pinecone_index.create()
7282
except Exception as e:
7383
assert False, f"Pinecone.create() failed with exception: {e}"
74-
assert isinstance(pinecone.index, oem_pinecone.Index)
75-
pinecone.delete()
84+
assert isinstance(pinecone_index.index, oem_pinecone.Index)
85+
pinecone_index.delete()
7686

7787
def test_07_load_pdf(self):
7888
"""Test that we can load a PDF document to the index."""

0 commit comments

Comments
 (0)