Skip to content

Commit 242d88f

Browse files
committed
refactor: change passwords to pydantic SecretStr
1 parent f7d1bf9 commit 242d88f

File tree

4 files changed

+18
-8
lines changed

4 files changed

+18
-8
lines changed

models/conf.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from typing import Any, Dict, List, Optional
2121

2222
from dotenv import load_dotenv
23-
from pydantic import Field, ValidationError, validator
23+
from pydantic import Field, SecretStr, ValidationError, validator
2424
from pydantic_settings import BaseSettings
2525

2626
from models.const import HERE
@@ -156,7 +156,7 @@ def __init__(self, **data: Any):
156156
openai_api_organization: Optional[str] = Field(
157157
SettingsDefaults.OPENAI_API_ORGANIZATION, env="OPENAI_API_ORGANIZATION"
158158
)
159-
openai_api_key: Optional[str] = Field(SettingsDefaults.OPENAI_API_KEY, env="OPENAI_API_KEY")
159+
openai_api_key: Optional[SecretStr] = Field(SettingsDefaults.OPENAI_API_KEY, env="OPENAI_API_KEY")
160160
openai_endpoint_image_n: Optional[int] = Field(
161161
SettingsDefaults.OPENAI_ENDPOINT_IMAGE_N, env="OPENAI_ENDPOINT_IMAGE_N"
162162
)
@@ -180,7 +180,7 @@ def __init__(self, **data: Any):
180180
SettingsDefaults.OPENAI_CHAT_MAX_RETRIES, env="OPENAI_CHAT_MAX_RETRIES"
181181
)
182182

183-
pinecone_api_key: Optional[str] = Field(SettingsDefaults.PINECONE_API_KEY, env="PINECONE_API_KEY")
183+
pinecone_api_key: Optional[SecretStr] = Field(SettingsDefaults.PINECONE_API_KEY, env="PINECONE_API_KEY")
184184
pinecone_environment: Optional[str] = Field(SettingsDefaults.PINECONE_ENVIRONMENT, env="PINECONE_ENVIRONMENT")
185185
pinecone_index_name: Optional[str] = Field(SettingsDefaults.PINECONE_INDEX_NAME, env="PINECONE_INDEX_NAME")
186186
pinecone_vectorstore_text_key: Optional[str] = Field(

models/hybrid_search_retreiver.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def chat(self) -> ChatOpenAI:
6969
"""ChatOpenAI lazy read-only property."""
7070
if self._chat is None:
7171
self._chat = ChatOpenAI(
72-
api_key=settings.openai_api_key,
72+
api_key=settings.openai_api_key.get_secret_value(), # pylint: disable=no-member
7373
organization=settings.openai_api_organization,
7474
cache=settings.openai_chat_cache,
7575
max_retries=settings.openai_chat_max_retries,
@@ -114,7 +114,11 @@ def prompt_with_template(
114114
self, prompt: PromptTemplate, concept: str, model: str = settings.openai_prompt_model_name
115115
) -> str:
116116
"""Prompt with template."""
117-
llm = OpenAI(model=model, api_key=settings.openai_api_key, organization=settings.openai_api_organization)
117+
llm = OpenAI(
118+
model=model,
119+
api_key=settings.openai_api_key.get_secret_value(), # pylint: disable=no-member
120+
organization=settings.openai_api_organization,
121+
)
118122
retval = llm(prompt.format(concept=concept))
119123
return retval
120124

models/pinecone.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,10 @@ def vector_store(self) -> LCPinecone:
105105
def openai_embeddings(self) -> OpenAIEmbeddings:
106106
"""OpenAIEmbeddings lazy read-only property."""
107107
if self._openai_embeddings is None:
108+
# pylint: disable=no-member
108109
self._openai_embeddings = OpenAIEmbeddings(
109-
api_key=settings.openai_api_key, organization=settings.openai_api_organization
110+
api_key=settings.openai_api_key.get_secret_value(),
111+
organization=settings.openai_api_organization,
110112
)
111113
return self._openai_embeddings
112114

@@ -126,7 +128,8 @@ def init_index(self):
126128

127129
def init(self):
128130
"""Initialize Pinecone."""
129-
pinecone.init(api_key=settings.pinecone_api_key, environment=settings.pinecone_environment)
131+
# pylint: disable=no-member
132+
pinecone.init(api_key=settings.pinecone_api_key.get_secret_value(), environment=settings.pinecone_environment)
130133
self._index = None
131134
self._index_name = None
132135
self._text_splitter = None

models/yt.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,10 @@ class LangChainDev:
6666
tool=PythonREPL(),
6767
verbose=True,
6868
)
69-
pinecone.init(api_key=settings.pinecone_api_key, environment=settings.pinecone_environment) # minute 10:43
69+
# pylint: disable=no-member
70+
pinecone.init(
71+
api_key=settings.pinecone_api_key.get_secret_value(), environment=settings.pinecone_environment
72+
) # minute 10:43
7073

7174
# LLM wrappers. minute 5:46
7275
def test_01_basic(self):

0 commit comments

Comments
 (0)