Fix bug in subset infinity (#141)

Author: FriesischScott

Project.toml

@@ -1,7 +1,10 @@
 name = "UncertaintyQuantification"
 uuid = "7183a548-a887-11e9-15ce-a56ab60bad7a"
-authors = ["Jasper Behrensdorf <behrensdorf@irz.uni-hannover.de>", "Ander Gray <ander.gray@liverpool.ac.uk>"]
-version = "0.8.0"
+authors = [
+    "Jasper Behrensdorf <behrensdorf@irz.uni-hannover.de>",
+    "Ander Gray <ander.gray@liverpool.ac.uk>",
+]
+version = "0.8.1"
 
 [deps]
 Bootstrap = "e28b5b4c-05e8-5b66-bc03-6f0c0a0a06e0"

src/simulations/subset.jl

@@ -239,19 +239,18 @@ function nextlevelsamples(
     inputs::Union{Vector{<:UQInput},UQInput},
     sim::SubSetInfinity,
 )
-    samples_per_seed = Int64(floor(sim.n / nrow(samples)))
+    samples_per_seed = Int64(floor(sim.n / length(performance)))
 
     random_inputs = filter(i -> isa(i, RandomUQInput), inputs)
     rvs = names(random_inputs)
 
-    to_standard_normal_space!(inputs, samples)
-
     samples = repeat(samples, samples_per_seed)
     performance = repeat(performance, samples_per_seed)
 
-    means = Matrix{Float64}(samples[:, rvs]) .* sqrt(1 - sim.s^2)
-
     nextlevelsamples = copy(samples)
+    to_standard_normal_space!(inputs, nextlevelsamples)
+
+    means = Matrix{Float64}(nextlevelsamples[:, rvs]) .* sqrt(1 - sim.s^2)
     nextlevelsamples[:, rvs] = randn(size(means)) .* sim.s .+ means
 
     to_physical_space!(inputs, nextlevelsamples)