Error on down site should be a warning for the user

[galou]

I get error uploading: HTTPSConnectionPool(host='eu.i.posthog.com', port=443): Max retries exceeded with url: /batch/ (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7eb460d09b70>: Failed to establish a new connection: [Errno -2] Name or service not known')) with error style.

This should be a warning since it doesn't prevent using FreeCAD or any addon. The text should also be more user-friendly.

[chennes]

I don't know how to catch that, it's coming from inside Posthog's python module: they aren't raising an exception for that condition, they just spit out the error message to stderr.

[hyarion]

@chennes this seems related: https://posthog.com/questions/catching-errors

[galou]

They say: "you could create a client and pass in the on_error argument which should be triggered whenever a background request error fails - github code". Do we have such a callback?

[hyarion]

No, we don't have that yet.

This is where we set up the client:
https://github.com/FreeCAD/FreeCAD-Telemetry/blob/main/PosthogFC.py#L59-L65

    posthog = Posthog(
        project_api_key=params.GetString(
            "PostHogAPIKey", "key"
        ),
        host=params.GetString("PostHogURL", "https://eu.i.posthog.com"),
        disable_geoip=True,
    )

It might work if we change it to something like:

    posthog = Posthog(
        project_api_key=params.GetString(
            "PostHogAPIKey", "key"
        ),
        host=params.GetString("PostHogURL", "https://eu.i.posthog.com"),
        disable_geoip=True,
        on_error=lambda e: None,
    )

This hasn't been tested though

[chennes]

That's how the Sentry API worked, I'd expect Posthog to be roughly the same. I probably won't just swallow the error like that, but the idea applies.

[chennes]

This should be fixed by b6f9fc5 -- @galou can you confirm?

[galou]

I'd prefer to let someone else confirm because, as a workbench developer, I often restart FreeCAD (like every 5 min when developing) and in that sense, my usage of FreeCAD is not that of a typical user. If nobody else confirms, I'll reinstall and test.