Ensure all threads are named for debugging

Author: chennes

addonmanager_installer_gui.py

@@ -329,6 +329,7 @@ def _run_dependency_installer(self, addons, python_requires, python_optional):
         self.dependency_installer.finished.connect(self._dependencies_finished)
 
         self.dependency_worker_thread = QtCore.QThread(self)
+        self.dependency_worker_thread.setObjectName("Dependency Installer Thread")
         self.dependency_installer.moveToThread(self.dependency_worker_thread)
         self.dependency_worker_thread.started.connect(self.dependency_installer.run)
 
@@ -445,6 +446,7 @@ def _cancel_dependency_installation(self) -> None:
     def install(self) -> None:
         """Installs or updates a workbench, macro, or package"""
         self.worker_thread = QtCore.QThread()
+        self.worker_thread.setObjectName("AddonInstallerGUI worker thread")
         self.installer.moveToThread(self.worker_thread)
         self.installer.finished.connect(self.worker_thread.quit)
         self.worker_thread.started.connect(self.installer.run)
@@ -551,6 +553,7 @@ def run(self):
         boxes. If installation proceeds successfully to completion, emits the success() signal."""
 
         self.worker_thread = QtCore.QThread()
+        self.worker_thread.setObjectName("MacroInstallerGUI worker thread")
         self.installer.moveToThread(self.worker_thread)
         self.installer.finished.connect(self.worker_thread.quit)
         self.installer.success.connect(self._base_installation_success)

addonmanager_package_details_controller.py

@@ -133,6 +133,9 @@ def show_repo(self, repo: Addon) -> None:
             self.ui.button_bar.check_for_update.setEnabled(True)
             if not self.update_check_thread:
                 self.update_check_thread = QtCore.QThread()
+                self.update_check_thread.setObjectName(
+                    "PackageDetailsController update check thread"
+                )
             self.check_for_update_worker = CheckSingleUpdateWorker(repo)
             self.check_for_update_worker.moveToThread(self.update_check_thread)
             self.update_check_thread.finished.connect(self.check_for_update_worker.deleteLater)

addonmanager_python_deps_gui.py

@@ -91,6 +91,7 @@ class CheckForPythonPackageUpdatesWorker(QtCore.QThread):
 
     def __init__(self):
         QtCore.QThread.__init__(self)
+        self.setObjectName("CheckForPythonPackageUpdatesWorker")
 
     def run(self):
         """Usually not called directly: instead, instantiate this class and call its start()
@@ -263,6 +264,7 @@ def _create_list_from_pip(self):
         showing in most cases."""
 
         self.worker_thread = QtCore.QThread()
+        self.worker_thread.setObjectName("CreateListFromPip worker thread")
         self.worker_object = PythonPackageManager.PipRunner(self.vendor_path)
         self.worker_object.moveToThread(self.worker_thread)
         self.worker_object.finished.connect(self._worker_finished)

addonmanager_uninstaller_gui.py

@@ -57,6 +57,7 @@ def __init__(self, addon_to_remove):
         self.uninstaller.success.connect(self._succeeded)
         self.uninstaller.failure.connect(self._failed)
         self.worker_thread = QtCore.QThread()
+        self.worker_thread.setObjectName("AddonUninstallerGUI worker thread")
         self.uninstaller.moveToThread(self.worker_thread)
         self.uninstaller.finished.connect(self.worker_thread.quit)
         self.worker_thread.started.connect(self.uninstaller.run)

addonmanager_update_all_gui.py

@@ -195,6 +195,7 @@ def _launch_active_installer(self):
         self.active_installer.finished.connect(self._update_finished)
 
         self.worker_thread = QtCore.QThread()
+        self.worker_thread.setObjectName("UpdateAllGUI worker thread")
         self.active_installer.moveToThread(self.worker_thread)
         self.worker_thread.started.connect(self.active_installer.run)
         self.worker_thread.start()

addonmanager_workers_installation.py

@@ -66,6 +66,7 @@ class RequestType(Enum):
     def __init__(self, repos):
 
         QtCore.QThread.__init__(self)
+        self.setObjectName("UpdateMetadataCacheWorker")
         self.repos = repos
         self.requests: Dict[int, (Addon, UpdateMetadataCacheWorker.RequestType)] = {}
         NetworkManager.AM_NETWORK_MANAGER.completed.connect(self.download_completed)

addonmanager_workers_startup.py

@@ -67,6 +67,7 @@ class CreateAddonListWorker(QtCore.QThread):
 
     def __init__(self):
         QtCore.QThread.__init__(self)
+        self.setObjectName("CreateAddonListWorker")
 
         # reject_listed addons
         self.macros_reject_list = []
@@ -440,6 +441,7 @@ class LoadPackagesFromCacheWorker(QtCore.QThread):
 
     def __init__(self, cache_file: str):
         QtCore.QThread.__init__(self)
+        self.setObjectName("LoadPackagesFromCacheWorker")
         self.cache_file = cache_file
         self.metadata_cache_path = os.path.join(
             fci.DataPaths().cache_dir, "AddonManager", "PackageMetadata"
@@ -479,6 +481,7 @@ class LoadMacrosFromCacheWorker(QtCore.QThread):
 
     def __init__(self, cache_file: str):
         QtCore.QThread.__init__(self)
+        self.setObjectName("LoadMacrosFromCacheWorker")
         self.cache_file = cache_file
 
     def run(self):
@@ -531,6 +534,7 @@ class CheckWorkbenchesForUpdatesWorker(QtCore.QThread):
     def __init__(self, repos: List[Addon]):
 
         QtCore.QThread.__init__(self)
+        self.setObjectName("CheckWorkbenchesForUpdatesWorker")
         self.repos = repos
         self.current_thread = None
         self.moddir = fci.DataPaths().mod_dir
@@ -746,6 +750,7 @@ class CacheMacroCodeWorker(QtCore.QThread):
 
     def __init__(self, repos: List[Addon]) -> None:
         QtCore.QThread.__init__(self)
+        self.setObjectName("CacheMacroCodeWorker")
         self.repos = repos
         self.workers = []
         self.terminators = []
@@ -893,6 +898,7 @@ class GetMacroDetailsWorker(QtCore.QThread):
     def __init__(self, repo):
 
         QtCore.QThread.__init__(self)
+        self.setObjectName("GetMacroDetailsWorker")
         self.macro = repo.macro
 
     def run(self):
@@ -930,6 +936,7 @@ class GetBasicAddonStatsWorker(QtCore.QThread):
 
     def __init__(self, url: str, addons: List[Addon], parent: QtCore.QObject = None):
         super().__init__(parent)
+        self.setObjectName("GetBasicAddonStatsWorker")
         self.url = url
         self.addons = addons
 
@@ -962,6 +969,7 @@ class GetAddonScoreWorker(QtCore.QThread):
 
     def __init__(self, url: str, addons: List[Addon], parent: QtCore.QObject = None):
         super().__init__(parent)
+        self.setObjectName("GetAddonScoreWorker")
         self.url = url
         self.addons = addons
 

addonmanager_workers_utility.py

@@ -49,6 +49,7 @@ class ConnectionChecker(QtCore.QThread):
 
     def __init__(self):
         QtCore.QThread.__init__(self)
+        self.setObjectName("ConnectionChecker")
         self.done = False
         self.request_id = None
         self.data = None

main.py

@@ -21,8 +21,6 @@
 # *                                                                         *
 # ***************************************************************************
 
-import AddonManager
-
 import sys
 
 # Check if PySide6 is used
@@ -43,6 +41,9 @@
 
 
 def run_addon_manager():
+    import AddonManager  # Must not be imported until there is a QApplication instance
+
+    QtCore.QThread.currentThread().setObjectName("Main GUI thread")
     command = AddonManager.CommandAddonManager()
     command.Activated()