Eliminate functions with mixed return strategies

Author: chennes

addonmanager_metadata.py

@@ -221,7 +221,7 @@ def get_first_supported_freecad_version(metadata: Metadata) -> Optional[Version]
     """Look through all content items of this metadata element and determine what the
     first version of freecad that ANY of the items support is. For example, if it
     contains several workbenches, some of which require v0.20, and some 0.21, then
-    0.20 is returned. Returns None if frecadmin is unset by any part of this object."""
+    0.20 is returned. Returns None if freecadmin is unset by any part of this object."""
 
     current_earliest = metadata.freecadmin if metadata.freecadmin is not None else None
     for content_class in metadata.content.values():
@@ -247,6 +247,7 @@ def get_repo_url_from_metadata(metadata: Metadata) -> str:
     for url in metadata.url:
         if url.type == UrlType.repository:
             return url.location
+    return ""
 
 
 class MetadataReader:

package_list.py

@@ -230,6 +230,9 @@ def data(self, index: QtCore.QModelIndex, role: int = QtCore.Qt.DisplayRole):
         if role == SortOptions.Score:
             return self.repos[row].score
 
+        # Anything else:
+        return None
+
     def headerData(self, _unused1, _unused2, _role=QtCore.Qt.DisplayRole):
         """No header in this implementation: always returns None."""
         return None