should the data option be passed to callback function of HMR's dispose function?

[MoonBall]

From the HMR doc, the dispose's callback function has a data param. Should we support it?

[FredKSchott]

Ah sorry, that code snippet is outdated. The new way to pass data is via https://github.com/pikapkg/esm-hmr#importmetahotdata

[gr2m]

so the fix for the snipped would be just remove the data parameter?

document.head.appendChild(styleEl);
  document.head.appendChild(styleEl);
-  import.meta.hot.dispose(({ data }) => {
+  import.meta.hot.dispose() => {
     document.head.removeChild(styleEl);
   });

[FredKSchott]

Correct! Looks like an outdated README, would love a PR to fix if you're able to.

Also, feels like it might be time to do that HMR deep dive with you :)

[MoonBall]

I made a PR FredKSchott/esm-hmr#18 to remove outdated doc.

[FredKSchott]

Fixed by @MoonBall !