Preserve async and defer attributes when using plugin-webpack

[jfranciscosousa]

When using plugin-webpack, any attribute that I set on the script tags gets erased after the build step. This question arose because I have an Eleventy website where I want to load all script tags with async/defer attributes. I could place them on the body tag to load them asynchronously anyway but one of those scripts has turbolinks and that must be included in the head.

I think it would be wise to preserve attributes on the original script tags. Looking at the code of the plugin I noticed it creates a new script tag with just a src attribute, perhaps we could copy the original script tag and just replace the src.

Any special reason why it works this way?

[jfranciscosousa]

By the way, I can open a PR for this if it makes sense. Tried something locally and it works.

[awu43]

Did you ever make that PR? Took me a while to figure out that losing defer was the source of my problem and this is definitely something I'd like to see fixed.

[jfranciscosousa]

I made a fork at the time and it was working nicely, can try to open a PR with that.

Eventually, I started using the new experimental optimizations that ship with 3.0. Those are preserving all attributes and for my use case it's even better than webpack.

I'll open it soon

[jfranciscosousa]

@andrew-1135 just merged #2498 I think it's fair to say this is fixed now.

[awu43]

Nicely done, much appreciated.