Skip to content

Commit e6270f5

Browse files
authored
Merge pull request #69 from FrangSierra/development
Development
2 parents 2b5b35c + a2a6d31 commit e6270f5

13 files changed

+264
-398
lines changed

app/build.gradle

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@ buildscript {
22
ext {
33
rx_version = "2.1.10"
44
rx_android_version = "2.0.2"
5-
firebase_auth_version='16.0.3'
6-
firebase_database_version='16.0.2'
7-
firebase_storage_version='16.0.2'
8-
firebase_firestore_version='17.1.0'
9-
firebase_functions_version='16.1.0'
5+
firebase_auth_version='16.0.5'
6+
firebase_database_version='16.0.4'
7+
firebase_storage_version='16.0.4'
8+
firebase_firestore_version='17.1.3'
9+
firebase_functions_version='16.1.3'
10+
firebase_remote_version='16.1.0'
1011
support_version = "27.0.2"
1112
}
1213
}
@@ -26,8 +27,8 @@ android {
2627
defaultConfig {
2728
minSdkVersion 14
2829
targetSdkVersion 28
29-
versionCode 5
30-
versionName "1.3"
30+
versionCode 6
31+
versionName "1.5.5"
3132
consumerProguardFiles 'consumer-proguard-rules.pro'
3233
}
3334
}
@@ -43,14 +44,16 @@ dependencies {
4344
compileOnly "com.google.firebase:firebase-storage:$firebase_storage_version"
4445
compileOnly "com.google.firebase:firebase-firestore:$firebase_firestore_version"
4546
compileOnly "com.google.firebase:firebase-functions:$firebase_functions_version"
46-
compileOnly "com.android.support:recyclerview-v7:$support_version"
47+
compileOnly "com.google.firebase:firebase-config:$firebase_remote_version"
48+
4749
implementation "io.reactivex.rxjava2:rxjava:$rx_version"
4850
implementation "io.reactivex.rxjava2:rxandroid:$rx_android_version"
4951

5052
testImplementation "com.google.firebase:firebase-auth:$firebase_auth_version"
5153
testImplementation "com.google.firebase:firebase-database:$firebase_database_version"
5254
testImplementation "com.google.firebase:firebase-storage:$firebase_storage_version"
5355
testImplementation "com.google.firebase:firebase-firestore:$firebase_firestore_version"
56+
testImplementation "com.google.firebase:firebase-config:$firebase_remote_version"
5457
testImplementation 'junit:junit:4.12'
55-
testImplementation "org.mockito:mockito-core:2.2.16"
58+
testImplementation "org.mockito:mockito-core:2.11.0"
5659
}

app/src/main/java/durdinapps/rxfirebase2/DataSnapshotMapper.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,16 @@ public static <U> DataSnapshotMapper<RxFirebaseChildEvent<DataSnapshot>, RxFireb
4444
}
4545

4646
private static <U> U getDataSnapshotTypedValue(DataSnapshot dataSnapshot, Class<U> clazz) {
47-
U value = dataSnapshot.getValue(clazz);
47+
U value;
48+
try {
49+
value = dataSnapshot.getValue(clazz);
50+
} catch (Exception ex) {
51+
throw Exceptions.propagate(new RxFirebaseDataCastException(
52+
"There was a problem trying to cast " + dataSnapshot.toString() + " to " + clazz.getSimpleName(), ex));
53+
}
4854
if (value == null) {
4955
throw Exceptions.propagate(new RxFirebaseDataCastException(
50-
"unable to cast firebase data response to " + clazz.getSimpleName()));
56+
"The value after cast " + dataSnapshot.toString() + " to " + clazz.getSimpleName() + "is null."));
5157
}
5258
return value;
5359
}

app/src/main/java/durdinapps/rxfirebase2/RxCompletableHandler.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99

1010
import io.reactivex.CompletableEmitter;
1111

12-
/**
13-
* Created by Durdin on 13/11/2016.
14-
*/
1512

1613
public class RxCompletableHandler implements OnFailureListener, OnSuccessListener, OnCompleteListener {
1714

app/src/main/java/durdinapps/rxfirebase2/RxFirebaseChildEvent.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
import android.support.annotation.NonNull;
55

6-
76
public class RxFirebaseChildEvent<T> {
87

98
private EventType eventType;

app/src/main/java/durdinapps/rxfirebase2/RxFirebaseRecyclerAdapter.java

Lines changed: 0 additions & 270 deletions
This file was deleted.

0 commit comments

Comments
 (0)