diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 87e4b8b3b..98fd7173f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -52,7 +52,6 @@ jobs: env: AZURE_ENV_NAME: ${{ github.run_id }} AZURE_LOCATION: ${{ vars.AZURE_LOCATION }} - AZURE_RESOURCE_GROUP: ${{ vars.AZURE_RESOURCE_GROUP }} with: imageName: ghcr.io/azure-samples/chat-with-your-data-solution-accelerator cacheFrom: ghcr.io/azure-samples/chat-with-your-data-solution-accelerator @@ -66,15 +65,12 @@ jobs: AZURE_SUBSCRIPTION_ID AZURE_ENV_NAME AZURE_LOCATION - AZURE_RESOURCE_GROUP - - name: Tidy up uses: devcontainers/ci@v0.3 if: always() env: AZURE_ENV_NAME: ${{ github.run_id }} AZURE_LOCATION: ${{ vars.AZURE_LOCATION }} - AZURE_RESOURCE_GROUP: ${{ vars.AZURE_RESOURCE_GROUP }} with: push: never imageName: ghcr.io/azure-samples/chat-with-your-data-solution-accelerator @@ -87,8 +83,7 @@ jobs: AZURE_SUBSCRIPTION_ID AZURE_ENV_NAME AZURE_LOCATION - AZURE_RESOURCE_GROUP - + - name: Send Notification on Failure if: failure() run: | diff --git a/Makefile b/Makefile index 6d816c65a..24c047929 100644 --- a/Makefile +++ b/Makefile @@ -57,14 +57,10 @@ azd-login: ## 🔑 Login to Azure with azd and a SPN @echo -e "\e[34m$@\e[0m" || true @azd auth login --client-id ${AZURE_CLIENT_ID} --client-secret ${AZURE_CLIENT_SECRET} --tenant-id ${AZURE_TENANT_ID} -az-login: ## 🔑 Login to Azure with az and a SPN - az login --service-principal -u ${AZURE_CLIENT_ID} -p ${AZURE_CLIENT_SECRET} --tenant ${AZURE_TENANT_ID} - -deploy: azd-login az-login ## 🚀 Deploy everything to Azure +deploy: azd-login ## 🚀 Deploy everything to Azure @echo -e "\e[34m$@\e[0m" || true @azd env new ${AZURE_ENV_NAME} @azd env set AZURE_APP_SERVICE_HOSTING_MODEL code --no-prompt - @az group create --name ${AZURE_RESOURCE_GROUP} --location ${AZURE_LOCATION} @azd provision --no-prompt @azd deploy web --no-prompt @azd deploy function --no-prompt diff --git a/infra/main.bicep b/infra/main.bicep index 480d89cbc..73d79ffd0 100644 --- a/infra/main.bicep +++ b/infra/main.bicep @@ -277,7 +277,7 @@ param principalId string = '' 'rbac' 'keys' ]) -param authType string = 'keys' +param authType string = 'rbac' @description('Hosting model for the web apps. Containers are prebuilt and can be deployed faster, but code allows for more customization.') @allowed([ diff --git a/infra/main.json b/infra/main.json index 0cc7ead7a..c6eeb7620 100644 --- a/infra/main.json +++ b/infra/main.json @@ -5,7 +5,7 @@ "_generator": { "name": "bicep", "version": "0.30.23.60470", - "templateHash": "11367626989637032545" + "templateHash": "16182560991627619456" } }, "parameters": { @@ -567,7 +567,7 @@ }, "authType": { "type": "string", - "defaultValue": "keys", + "defaultValue": "rbac", "allowedValues": [ "rbac", "keys"