fix test errors

Author: mq-bot

metagpt/actions/action_node.py

@@ -567,23 +567,23 @@ async def xml_fill(self, context: str, images: Optional[Union[str, list[str]]] =
                 raw_value = match.group(1).strip()
                 field_type = field_types.get(field_name)
 
-                if field_type == str:
+                if field_type is str:
                     extracted_data[field_name] = raw_value
-                elif field_type == int:
+                elif field_type is int:
                     try:
                         extracted_data[field_name] = int(raw_value)
                     except ValueError:
                         extracted_data[field_name] = 0  # 或者其他默认值
-                elif field_type == bool:
+                elif field_type is bool:
                     extracted_data[field_name] = raw_value.lower() in ("true", "yes", "1", "on", "True")
-                elif field_type == list:
+                elif field_type is list:
                     try:
                         extracted_data[field_name] = eval(raw_value)
                         if not isinstance(extracted_data[field_name], list):
                             raise ValueError
                     except:
                         extracted_data[field_name] = []  # 默认空列表
-                elif field_type == dict:
+                elif field_type is dict:
                     try:
                         extracted_data[field_name] = eval(raw_value)
                         if not isinstance(extracted_data[field_name], dict):

metagpt/ext/sela/insights/solution_designer.py

@@ -137,7 +137,7 @@ class SolutionDesigner:
 
     async def generate_solutions(self, dataset_info, dataset_name, save_analysis_pool=True):
         llm = LLM()
-        if type(dataset_info) == dict:
+        if isinstance(dataset_info, dict):
             description_prompt = DATASET_DESCRIPTION_SELA_PROMPT.format(
                 dataset=dataset_info["description"],
                 metadata=self.metadata_builder(dataset_info["metadata"]),

metagpt/roles/role.py

@@ -315,10 +315,7 @@ def set_env(self, env: BaseEnvironment):
             self.llm.cost_manager = self.context.cost_manager
             self.set_actions(self.actions)  # reset actions to update llm and prefix
 
-    @property
-    def name(self):
-        """Get the role name"""
-        return self._setting.name
+    # Removed property `name` that redefined the field and violated F811
 
     def _get_prefix(self):
         """Get the role prefix"""

metagpt/utils/human_interaction.py

@@ -28,7 +28,7 @@ def multilines_input(self, prompt: str = "Enter: ") -> str:
 
     def check_input_type(self, input_str: str, req_type: Type) -> Tuple[bool, Any]:
         check_ret = True
-        if req_type == str:
+        if req_type is str:
             # required_type = str, just return True
             return check_ret, input_str
         try:

requirements.txt

@@ -4,7 +4,7 @@ channels==4.0.0
 # Django==4.1.5
 # docx==0.2.4
 #faiss==1.5.3
-faiss_cpu==1.7.4
+faiss_cpu==1.12.0
 fire==0.4.0
 typer==0.9.0
 # godot==0.1.1

tests/metagpt/serialize_deserialize/test_environment.py

@@ -53,8 +53,8 @@ def test_environment_serdeser(context):
 
     assert list(new_env.roles.values())[0].states == list(environment.roles.values())[0].states
     assert isinstance(list(environment.roles.values())[0].actions[0], ActionOK)
-    assert type(list(new_env.roles.values())[0].actions[0]) == ActionOK
-    assert type(list(new_env.roles.values())[0].actions[1]) == ActionRaise
+    assert isinstance(list(new_env.roles.values())[0].actions[0], ActionOK)
+    assert isinstance(list(new_env.roles.values())[0].actions[1], ActionRaise)
     assert list(new_env.roles.values())[0].rc.watch == role_c.rc.watch
 
 
@@ -86,7 +86,7 @@ def test_environment_serdeser_save(context):
     env_dict = read_json_file(env_path)
     new_env: Environment = Environment(**env_dict, context=context)
     assert len(new_env.roles) == 1
-    assert type(list(new_env.roles.values())[0].actions[0]) == ActionOK
+    assert isinstance(list(new_env.roles.values())[0].actions[0], ActionOK)
     assert list(new_env.roles.values())[0].rc.watch == role_c.rc.watch
 
 

tests/metagpt/serialize_deserialize/test_prepare_interview.py

@@ -16,4 +16,4 @@ async def test_action_serdeser(context):
     new_action = PrepareInterview(**serialized_data, context=context)
 
     assert new_action.name == "PrepareInterview"
-    assert type(await new_action.run("python developer")) == ActionNode
+    assert isinstance(await new_action.run("python developer"), ActionNode)

tests/metagpt/serialize_deserialize/test_team.py

@@ -42,7 +42,7 @@ def test_team_deserialize(context):
     assert new_company.env.get_role(pm.profile) is not None
 
     new_pm = new_company.env.get_role(pm.profile)
-    assert type(new_pm) == ProductManager
+    assert isinstance(new_pm, ProductManager)
     assert new_company.env.get_role(pm.profile) is not None
     assert new_company.env.get_role(arch.profile) is not None
 
@@ -89,7 +89,7 @@ async def test_team_recover(mocker, context):
     new_role_c = new_company.env.get_role(role_c.profile)
     assert new_role_c.rc.memory == role_c.rc.memory
     assert new_role_c.rc.env != role_c.rc.env
-    assert type(list(new_company.env.roles.values())[0].actions[0]) == ActionOK
+    assert isinstance(list(new_company.env.roles.values())[0].actions[0], ActionOK)
 
     new_company.run_project(idea)
     await new_company.run(n_round=4)

tests/metagpt/serialize_deserialize/test_write_review.py

@@ -51,6 +51,6 @@ async def test_action_serdeser(context):
     review = await new_action.run(TEMPLATE_CONTEXT)
 
     assert new_action.name == "WriteReview"
-    assert type(review) == ActionNode
+    assert isinstance(review, ActionNode)
     assert review.instruct_content
     assert review.get("LGTM") in ["LGTM", "LBTM"]