Skip to content

Commit 585f756

Browse files
committed
Updates per Simone's review
1 parent e01c867 commit 585f756

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- uses: actions/setup-node@v4
2727
with:
2828
cache: 'pnpm'
29-
node-version: 22.x
29+
node-version-file: .nvmrc
3030

3131
# Wireit cache
3232
- uses: google/wireit@setup-github-actions-caching/v2

.github/workflows/create-spectacle.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ jobs:
2121
runs-on: ubuntu-latest
2222
strategy:
2323
matrix:
24-
node-version: [22.x]
2524
create-type: ['tsx', 'onepage']
2625
steps:
2726
- uses: actions/checkout@v4
@@ -33,7 +32,7 @@ jobs:
3332
- uses: actions/setup-node@v4
3433
with:
3534
cache: 'pnpm'
36-
node-version: ${{ matrix.node-version }}
35+
node-version-file: .nvmrc
3736

3837
# Wireit cache
3938
- uses: google/wireit@setup-github-actions-caching/v2

.github/workflows/release.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,10 @@ jobs:
3131
- uses: actions/setup-node@v4
3232
with:
3333
cache: 'pnpm'
34-
node-version: 22.x
34+
node-version-file: .nvmrc
3535

3636
- name: Upgrade npm for OIDC
37-
run: npm i -g npm@^11.5.1
38-
39-
- name: Set npm registry for OIDC
40-
run: npm config set registry https://registry.npmjs.org
37+
run: npm i -g npm@>=11.5.1
4138

4239
- name: Install dependencies
4340
run: pnpm install

0 commit comments

Comments
 (0)