Skip to content

Commit cdf9400

Browse files
author
Kadi Kraman
committed
Add return params in a consistent order for iOS and Android
1 parent 100b9a8 commit cdf9400

File tree

3 files changed

+14
-16
lines changed

3 files changed

+14
-16
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ Must be string values! E.g. setting `additionalParameters: { hello: 'world', foo
6868

6969
This is the result from the auth server
7070
- **accessToken** - (`string`) the access token
71-
- **tokenType** - (`string`) the token type, e.g. Bearer
7271
- **accessTokenExpirationDate** - (`string`) the token expiration date
73-
- **refreshToken** - (`string`) the refresh token
74-
- **idToken** - (`string`) the id token
7572
- **additionalParameters** - (`Object`) additional url parameters from the auth server
73+
- **idToken** - (`string`) the id token
74+
- **refreshToken** - (`string`) the refresh token
75+
- **tokenType** - (`string`) the token type, e.g. Bearer
7676

7777
### `refresh`
7878

android/src/main/java/com/reactlibrary/RNAppAuthModule.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,6 @@ private WritableMap tokenResponseToMap(TokenResponse response) {
5959
Date expirationDate = new Date(response.accessTokenExpirationTime);
6060
SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ");
6161
String expirationDateString = formatter.format(expirationDate);
62-
63-
WritableMap map = Arguments.createMap();
64-
map.putString("accessToken", response.accessToken);
65-
map.putString("tokenType", response.tokenType);
66-
map.putString("accessTokenExpirationDate", expirationDateString);
67-
map.putString("refreshToken", response.refreshToken);
68-
map.putString("idToken", response.idToken);
69-
7062
WritableMap additionalParametersMap = Arguments.createMap();
7163

7264
if (!response.additionalParameters.isEmpty()) {
@@ -81,7 +73,13 @@ private WritableMap tokenResponseToMap(TokenResponse response) {
8173
map.putMap("additionalParameters", additionalParametersMap);
8274
}
8375

76+
WritableMap map = Arguments.createMap();
77+
map.putString("accessToken", response.accessToken);
78+
map.putString("accessTokenExpirationDate", expirationDateString);
8479
map.putMap("additionalParameters", additionalParametersMap);
80+
map.putString("idToken", response.idToken);
81+
map.putString("refreshToken", response.refreshToken);
82+
map.putString("tokenType", response.tokenType);
8583

8684
return map;
8785
}

ios/RNAppAuth.m

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ - (dispatch_queue_t)methodQueue
5757

5858
NSDictionary *authStateDict = @{
5959
@"accessToken": authState.lastTokenResponse.accessToken,
60-
@"tokenType": authState.lastTokenResponse.tokenType,
6160
@"accessTokenExpirationDate": exporationDateString,
61+
@"additionalParameters": authState.lastTokenResponse.additionalParameters,
6262
@"idToken": authState.lastTokenResponse.idToken,
6363
@"refreshToken": authState.lastTokenResponse.refreshToken ? authState.lastTokenResponse.refreshToken : @"",
64-
@"additionalParameters": authState.lastTokenResponse.additionalParameters,
64+
@"tokenType": authState.lastTokenResponse.tokenType,
6565
};
6666
resolve(authStateDict);
6767
} else {
@@ -118,11 +118,11 @@ - (dispatch_queue_t)methodQueue
118118

119119
resolve(@{
120120
@"accessToken": response.accessToken ? response.accessToken : @"",
121-
@"refreshToken": response.refreshToken ? response.refreshToken : @"",
122121
@"accessTokenExpirationDate": exporationDateString,
123-
@"tokenType": response.tokenType ? response.tokenType : @"",
124-
@"idToken": response.idToken ? response.idToken : @"",
125122
@"additionalParameters": response.additionalParameters,
123+
@"idToken": response.idToken ? response.idToken : @"",
124+
@"refreshToken": response.refreshToken ? response.refreshToken : @"",
125+
@"tokenType": response.tokenType ? response.tokenType : @"",
126126
});
127127
} else {
128128
reject(@"RNAppAuth Error", [error localizedDescription], error);

0 commit comments

Comments
 (0)